Plugin integration for 'mini.nvim' #29
-
|
I'd like to work on a PR to submit tuned highlight groups for 'mini.nvim' and its 40+ modules. However, before even starting, I'm having a problem as I'm not sure I understand how the integration system is supposed to work. Based on my cursory review, it looks like I should be able to add each to I'm not sure if this is a reliable means to load integrations. Catppuccin requires one to enable specific integrations in their configuration (above and beyond the ones they include by default). They do have a special auto-detection that only works if one uses 'lazy.vim' as their package manager, but I don't use 'lazy.vim' though as I've switched to the new builtin package manager in neovim 0.12+. Any thoughts? |
Beta Was this translation helpful? Give feedback.
Replies: 19 comments 37 replies
-
|
You are right, you would need to add each to On review, I think you are right that the I don't like the idea of loading all integrations up front in theory, but in practice, the performance difference is less than As the plugin grows and incorporates more integrations, it might be worth it to revisit. Maybe the best solution is simply to defer the problem to the user by adding an opt-in table within their config for them to enable/disable integrations to load? But for now, it's probably unnecessary. What do you think? |
Beta Was this translation helpful? Give feedback.
-
|
'mini.pick' has a prompt that is part of the floating window's border, so I was looking for the correct bg color and came across an inconsistency that I did not understand. In short, c.ui.float.bg, which seemed like the obvious choice until I realized it points to ui.bg.surface, yet NormalFloat points to c.bg.mantle. Thanks. |
Beta Was this translation helpful? Give feedback.
-
|
BTW, I've completed 6 of the 'mini.nvim' plugins so far. I spent a lot of time futzing with the pmenu stuff, so I was distracted. I was thinking of creating a thread for each integration showing the before and after screenshots as well as the hl changes for your approval. Would the work for you? Then when I've finished everything, I'll submit one PR. |
Beta Was this translation helpful? Give feedback.
-
|
Another question re: |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
As I work on 'mini.statusline', I'm trying to settle on the look for the filename portion of the statusline. There are two options for me to consider looking at your existing codebase (all use same bg, so no question on that part):
IMO, I like option 1. Maybe the inactive fg bumped up just a tad to |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
mini.jump'mini.jump' is a replacement for Configurationreturn function(c)
return {
MiniJump = { undercurl = true, sp = c.theme.cursor },
}
endScreenshots |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
mini.starter'mini.starter' is a startup screen. Configurationreturn function(c)
return {
MiniStarterFooter = "Comment",
MiniStarterInactive = { fg = c.fg.muted },
MiniStarterItemPrefix = { fg = c.theme.strong_primary, bold = true },
MiniStarterQuery = { fg = c.theme.accent, bold = true },
MiniStarterSection = "OasisSecondary",
}
endScreenshots |
Beta Was this translation helpful? Give feedback.
-
mini.trailspace'mini.trailspace' highlights and allows one to remove trailing whitespace. Configurationreturn function(c)
return {
MiniTrailspace = { bg = c.syntax.exception },
}
endScreenshots
|
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Okay, that concludes all of the 'mini.nvim' modules that need tuning for Oasis. Once you're comfortable with the above, let me know and I'll open a single PR with all of the integrations to provide Oasis first-class 'mini.nvim' support. Thanks for all of your help as I worked through these. |
Beta Was this translation helpful? Give feedback.


























































You are right, you would need to add each to
PLUGIN_MODULESand then it would load the highlight group for that module from the.../integrations/plugins/directory.On review, I think you are right that the
package.loadedis not doing its job properly due to race conditions with lazy loading plugins. I have commented this out for now and will revisit it later. You can now update the plugin and proceed with anymini.nvimintegrations without obstruction 😄I don't like the idea of loading all integrations up front in theory, but in practice, the performance difference is less than
0.01 mson my system, so this is a very low-priority item if it even is one at all.As the plugin grows and in…