Skip to content

feat: show selection stats in footer #31

feat: show selection stats in footer

feat: show selection stats in footer #31

Triggered via push June 10, 2026 05:52
Status Success
Total duration 2m 29s
Artifacts

ci.yml

on: push
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

6 warnings and 1 notice
manual `!Range::contains` implementation: src/widget/table/mod.rs#L256
warning: manual `!Range::contains` implementation --> src/widget/table/mod.rs:256:8 | 256 | if abs < 1e-6 || abs >= 1e12 { | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(1e-6..1e12).contains(&abs)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#manual_range_contains
manual `!Range::contains` implementation: src/screen/editor/navigation.rs#L242
warning: manual `!Range::contains` implementation --> src/screen/editor/navigation.rs:242:8 | 242 | if abs < 1e-6 || abs >= 1e12 { | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(1e-6..1e12).contains(&abs)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#manual_range_contains = note: `#[warn(clippy::manual_range_contains)]` on by default
call to `std::mem::drop` with a value that does not implement `Drop`. Dropping such a type only extends its contained lifetimes: src/model/formula/mod.rs#L46
warning: call to `std::mem::drop` with a value that does not implement `Drop`. Dropping such a type only extends its contained lifetimes --> src/model/formula/mod.rs:46:5 | 46 | drop(reader); | ^^^^^^^^^^^^ | note: argument has type `model::formula::WorkbookReader<'_>` --> src/model/formula/mod.rs:46:10 | 46 | drop(reader); | ^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#drop_non_drop = note: `#[warn(clippy::drop_non_drop)]` on by default
redundant closure: src/model/formula/mod.rs#L39
warning: redundant closure --> src/model/formula/mod.rs:39:53 | 39 | let new_val = result.unwrap_or_else(|e| CellValue::Error(e)); | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `CellValue::Error` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#redundant_closure = note: `#[warn(clippy::redundant_closure)]` on by default
this `if` statement can be collapsed: src/model/formula/mod.rs#L36
warning: this `if` statement can be collapsed --> src/model/formula/mod.rs:36:9 | 36 | / if let Some(cell) = wb.cells.get(&addr) { 37 | | if cell.raw.starts_with('=') { 38 | | let result = evaluator.eval_cell(addr); 39 | | let new_val = result.unwrap_or_else(|e| CellValue::Error(e)); ... | 42 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#collapsible_if = note: `#[warn(clippy::collapsible_if)]` on by default help: collapse nested if block | 36 ~ if let Some(cell) = wb.cells.get(&addr) 37 ~ && cell.raw.starts_with('=') { 38 | let result = evaluator.eval_cell(addr); 39 | let new_val = result.unwrap_or_else(|e| CellValue::Error(e)); 40 | updates.push((addr, new_val)); 41 ~ } |
stripping a prefix manually: src/model/formula/eval.rs#L50
warning: stripping a prefix manually --> src/model/formula/eval.rs:50:27 | 50 | let formula = &raw[1..]; | ^^^^^^^^^ | note: the prefix was tested here --> src/model/formula/eval.rs:49:9 | 49 | if raw.starts_with('=') { | ^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#manual_strip = note: `#[warn(clippy::manual_strip)]` on by default help: try using the `strip_prefix` method | 49 ~ if let Some(formula) = raw.strip_prefix('=') { 50 ~ self.evaluating.insert(addr); |
test windows-latest
NOTICE: windows-latest requests are being redirected to windows-2025-vs2026 by June 15, 2026