Merge branch 'fix/raps-edit-permissions' into Development

Author: bniedzie

test/RAPS/EmptyDateBindingTests.cs

@@ -25,8 +25,8 @@ public void MemberPermissionBody_WithRealDates_StillBinds()
             var model = DeserializeMemberPermission(
                 @"{""memberId"":""12345678"",""permissionId"":5,""access"":1,""startDate"":""2026-01-15T00:00:00"",""endDate"":""2026-06-30T00:00:00""}");
 
-            Assert.Equal(new DateTime(2026, 1, 15, 0, 0, 0, DateTimeKind.Local), model.StartDate);
-            Assert.Equal(new DateTime(2026, 6, 30, 0, 0, 0, DateTimeKind.Local), model.EndDate);
+            Assert.Equal(new DateTime(2026, 1, 15, 0, 0, 0, DateTimeKind.Unspecified), model.StartDate);
+            Assert.Equal(new DateTime(2026, 6, 30, 0, 0, 0, DateTimeKind.Unspecified), model.EndDate);
         }
 
         [Fact]
@@ -51,7 +51,7 @@ public void MemberPermission_RoundTripsThroughSerialization()
                 MemberId = "12345678",
                 PermissionId = 5,
                 Access = 1,
-                StartDate = new DateTime(2026, 1, 15, 0, 0, 0, DateTimeKind.Local),
+                StartDate = new DateTime(2026, 1, 15, 0, 0, 0, DateTimeKind.Unspecified),
                 EndDate = null
             };
 
@@ -60,7 +60,7 @@ public void MemberPermission_RoundTripsThroughSerialization()
                 JsonSerializer.Deserialize<MemberPermissionCreateUpdate>(json, JsonSerializerOptions.Web);
 
             Assert.NotNull(result);
-            Assert.Equal(new DateTime(2026, 1, 15, 0, 0, 0, DateTimeKind.Local), result.StartDate);
+            Assert.Equal(new DateTime(2026, 1, 15, 0, 0, 0, DateTimeKind.Unspecified), result.StartDate);
             Assert.Null(result.EndDate);
         }
 

web/Classes/Utilities/EmptyStringAsNullConverter.cs

@@ -8,15 +8,13 @@ namespace Viper.Classes.Utilities;
 /// A cleared date input posts "", which System.Text.Json otherwise rejects for
 /// DateTime?/DateOnly?, failing model binding with a 400 before the action runs.
 /// Apply per property with [JsonConverter(typeof(EmptyStringAsNullConverter<DateTime>))].
+/// A JSON null never reaches these methods: HandleNull defaults to false for a
+/// converter over Nullable<T>, so System.Text.Json reads and writes null itself.
 /// </summary>
 public class EmptyStringAsNullConverter<T> : JsonConverter<T?> where T : struct
 {
     public override T? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
     {
-        if (reader.TokenType == JsonTokenType.Null)
-        {
-            return null;
-        }
         if (reader.TokenType == JsonTokenType.String && string.IsNullOrWhiteSpace(reader.GetString()))
         {
             return null;
@@ -27,13 +25,10 @@ public class EmptyStringAsNullConverter<T> : JsonConverter<T?> where T : struct
 
     public override void Write(Utf8JsonWriter writer, T? value, JsonSerializerOptions options)
     {
+        // Nothing to write when null, since that case is handled before it gets here.
         if (value.HasValue)
         {
             JsonSerializer.Serialize(writer, value.Value, options);
         }
-        else
-        {
-            writer.WriteNullValue();
-        }
     }
 }