Skip to content

[Feedback]: Idiomatic rust #3

Description

@Uzaaft

Just some general feedback on your code:

  1. For your struct Place(line 9-13), you seem to implement a default implemention for your struct with arbritary values. This can be reduced to:
#[derive(Default)]
struct Place {
    x: i32,
    y: i32,
    z: i32
}

Which will implement default values for your struct(most likely just 0's).

  1. From line 83-89
    You can use iter().map() instead, which is moe in line with idiomatic rust.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions