diff --git a/bin/idl.js b/bin/idl.js index 8e2ad0f..0f13bf0 100755 --- a/bin/idl.js +++ b/bin/idl.js @@ -31,7 +31,6 @@ var mkdirp = require('mkdirp'); var DebugLogtron = require('debug-logtron'); var extend = require('xtend'); var textTable = require('text-table'); -var parallel = require('run-parallel'); var cpr = require('cpr'); var rc = require('rc'); var rcUtils = require('rc/lib/utils'); @@ -484,7 +483,7 @@ function fetch(service, cb) { self.update(onUpdate); function onUpdate(err) { - if (err != null) { + if (!err) { return cb(err); } @@ -524,7 +523,6 @@ function fetchOneService(service, cb) { return cb(err); } - var alreadyFetched = findService(localMeta.toJSON(), service); var existsInRegistry = findService(self.meta.toJSON(), service); if (!existsInRegistry) { @@ -1019,7 +1017,8 @@ function toString() { } // If configured in .idlrc, runs a command that ensures that subsequent git -// commands interacting with the git registry's repository run without interactive authentication prompts. +// commands interacting with the git registry's repository run without +// interactive authentication prompts. // This is important since these command typically run in a pty to obscure hide // their output and detect any interactive authentication prompts (via PAM) // that might open /dev/tty to avoid mucking with stdio. diff --git a/git-commands.js b/git-commands.js index 183df33..f1f4c1e 100644 --- a/git-commands.js +++ b/git-commands.js @@ -36,7 +36,7 @@ function addCommitTagAndPushToOrigin(opts, callback) { var ctx = { cwd: opts.cwd, logger: opts.logger, - debugGit: opts.debugGit, + debugGit: opts.debugGit }; series([ diff --git a/test/unit/get-dependencies.js b/test/unit/get-dependencies.js index f08112a..6c4594f 100644 --- a/test/unit/get-dependencies.js +++ b/test/unit/get-dependencies.js @@ -98,7 +98,7 @@ test('getServiceDependenciesFromIncludes', 'github.com/a-team/bar', 'github.com/b-team/baz', 'github.com/b-team/qux', - 'github.com/company/common', + 'github.com/company/common' ]; assert.deepEqual(serviceDependencies, expected);