E-mail sending: illegal header: Old-Return-Path

Trying to send SMS messages from OpenVBX through Amazon SMTP and this is the error being reported, which might be very much relevant to OpenVBX:

Your message to the following recipients cannot be delivered:

support1@example.com:
ses-smtp-prod-335357831.us-east-1.elb.amazonaws.com [174.129.24.189]:

DATA
<<< 554 Transaction failed: Illegal header 'Old-Return-Path'.

[frederickding]

I also noticed that in OpenVBX/helpers/mail_helper.php, the mail() function is hardcoded. Wouldn't it make more sense to tap into CodeIgniter's email library?

[frederickding]

Here's my modification to mail_helper.php to make it use CodeIgniter's email library, which can be configured to use SMTP, sendmail, or mail(). It's ridiculously simple to use.

(I would send a pull request, but I haven't actually forked this repo yet.)

https://gist.github.com/frederickding/7837728

$message = $ci->load->view('emails/'.$template, $maildata, true);

$ci->load->library('email');
$ci->email->clear();
$ci->email->from($from_email);
$ci->email->reply_to($from_email);
$ci->email->to($recipient);
$ci->email->subject($subject);
$ci->email->message($message);

log_message('debug', 'MAILING -- to: '.$recipient.' -- body: '.$message);

return $ci->email->send();

[LloydSilver]

Hopefully you can help. I tried implementing the above solution to send email via php but when I save a new user I get the following message:

An unknown error occurred. Please contact your OpenVBX provider. Unable to complete request: http://openvbx.xxxxxx.com/accounts/user/save

The user is created despite the error. But no email is being sent.

I edited the config/email.php as follows:

$config['useragent'] = 'CodeIgniter'; //The "user agent". $config['protocol'] = 'smtp'; //mail, sendmail, or smtp The mail sending protocol. $config['mailpath'] = '/usr/sbin/sendmail'; //The server path to Sendmail.

/*
SMTP Settings
Use if protocol set to smtp above; otherwise ignore
-------------------------------------------------------------------
*/

$config['smtp_host'] = 'ssl://xxxxxxxx.com'; //SMTP Server Address.
$config['smtp_user'] = 'vbx@xxxxxxxx.com'; //SMTP Username.
$config['smtp_pass'] = 'xxxxxxxxx'; //SMTP Password.
$config['smtp_port'] = '465'; // SMTP Port.
$config['smtp_timeout'] = '10'; // SMTP Timeout (in seconds).


And I edited mail_helper.php, using your code, as follows:

function openvbx_mail($recipient, $subject, $template, $maildata = array()) { $ci = &get_instance();

$from_email = $ci->settings->get('from_email', $ci->tenant->id);
if(empty($from_email))
{
    $domain = $ci->config->item('server_name');
    $from_email = "$from <do-not-reply@$domain>";
}

$message = $ci->load->view('emails/'.$template, $maildata, true);

$ci->load->library('email');
$ci->email->clear();
$ci->email->from($from_email);
$ci->email->reply_to($from_email);
$ci->email->to($recipient);
$ci->email->subject($subject);
$ci->email->message($message);

log_message('debug', 'MAILING -- to: '.$recipient.' -- body: '.$message);

return $ci->email->send();

}


Any idea what I'm doing wrong. I'd greatly appreciate some help. Thanks.

[frederickding]

The code looks fine, but a lot of the bugginess might be due to OpenVBX using an older version of the CodeIgniter library.

Edit: you might also be facing this issue: http://blog.daanraman.com/coding/codeigniter/sending-smtp-mail-through-gmail-in-codeigniter/

My forked version of OpenVBX fixes this mail_helper.php and also uses a newer version of the library. See https://github.com/frederickding/OpenVBX/blob/master/OpenVBX/helpers/mail_helper.php for the code and https://github.com/frederickding/OpenVBX for the fork.

[LloydSilver]

Oh awesome. I’ll reinstall using your fork. Thanks so much for the quick response. Very appreciated.

From: Frederick Ding [mailto:notifications@github.com]
Sent: Sunday, February 02, 2014 1:48 PM
To: twilio/OpenVBX
Cc: LloydSilver
Subject: Re: [OpenVBX] E-mail sending: illegal header: Old-Return-Path (#255)

The code looks fine, but a lot of the bugginess might be due to OpenVBX using an older version of the CodeIgniter library.

My forked version of OpenVBX fixes this mail_helper.php and also uses a newer version of the library. See https://github.com/frederickding/OpenVBX/blob/master/OpenVBX/helpers/mail_helper.php for the code and https://github.com/frederickding/OpenVBX for the fork.

—
Reply to this email directly or view it on GitHub #255 (comment) . https://github.com/notifications/beacon/4335058__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwNjkxMDQ5OSwiZGF0YSI6eyJpZCI6MTk1NTg2MzB9fQ==--e848f889164a6686d1561a2801991437919faecf.gif

[Gipetto]

@frederickding How confident are you about the system as a whole with your CI Upgrade? Can you open a pull request so I can take a look? I once upon a time had a branch that did this but never got a chance to fully test it out.

[frederickding]

@Gipetto Pretty confident. It's been in light use for a few months on an nginx/1.4.4 PHP-FPM/5.5.8 system; memcache also appears to work. I've opened up the pull request: #260

[Gipetto]

Excellent. Its my plan to hopefully get some of the user-contributions processed and clear out the backlog of still valid pull requests in the next few weeks.