Skip to content

Possible Incorrect Foot Point Calculation in get_img_gt function #6

Description

@visionNoob

👋 Hi, I found a possible issue with the calculation of foot_pts in the get_img_gt function.

In the current implementation:

foot_pts = np.stack(((xmin + xmax) / 2, ymin), axis=1)
foot_pts = torch.tensor(foot_pts, dtype=torch.float32)

It seems that ymin is used as the foot position (Y-coordinate), but ymin typically represents the top of the bounding box (head position) rather than the bottom.

Wouldn't it make more sense to use ymax instead?
For example:

foot_pts = np.stack(((xmin + xmax) / 2, ymax), axis=1)
foot_pts = torch.tensor(foot_pts, dtype=torch.float32)

This way, foot_pts would represent the actual bottom of the bounding box, which is more aligned with the foot position.

Image

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions