Skip to content

Commit 7529c33

Browse files
authored
ci: correct testcontainer pre-pull image lists (#4685)
## What Three corrections to the pre-pull lists, each verified against what the suites actually use. ## Changes **`ryuk:0.11.0` -> `0.14.0`** in `e2e-webapp.yml` and `e2e-webapp-auth-full.yml`. The installed testcontainers hardcodes the image it starts: ```js // testcontainers@11.14.0 build/reaper/reaper.js : ImageName.fromString("testcontainers/ryuk:0.14.0").string; ``` So those two lines were pre-pulling an image nothing starts, and the one actually used was never pre-pulled. The other three workflows already say 0.14.0. **`postgres:17` added** to `unit-tests-webapp.yml`. The webapp suite references `docker.io/postgres:17` across 10 files but only `postgres:14` was pre-pulled. `unit-tests-internal.yml` already pulls both. **Electric pinned to its digest** in `unit-tests-webapp.yml`. The tests run `electricsql/electric:1.2.4@sha256:20da...` while the pre-pull asked for the bare tag, so the pre-pull did not necessarily populate the manifest the tests then request. ## Not changed The otel collector and s2 images are pulled by other workflows but are not used by the webapp suite, so they are deliberately not added here. `postgresAndRedisTest` uses per-test containers by design and needs nothing pre-pulled.
1 parent 9de90f7 commit 7529c33

5 files changed

Lines changed: 4 additions & 5 deletions

File tree

.github/workflows/e2e-webapp-auth-full.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ jobs:
102102
run: |
103103
docker pull postgres:14
104104
docker pull redis:7.2
105-
docker pull testcontainers/ryuk:0.11.0
105+
docker pull testcontainers/ryuk:0.14.0
106106
107107
- name: 📥 Download deps
108108
run: pnpm install --frozen-lockfile

.github/workflows/e2e-webapp.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ jobs:
7878
echo "Pre-pulling Docker images with authenticated session..."
7979
docker pull postgres:14
8080
docker pull redis:7.2
81-
docker pull testcontainers/ryuk:0.11.0
81+
docker pull testcontainers/ryuk:0.14.0
8282
docker pull ghcr.io/s2-streamstore/s2:0.40.0@sha256:b26249e2ede0949755f5af8028185dc2bcfc3aa2db21eb9610543d144eb6ee9d
8383
docker pull minio/minio:latest
8484
echo "Image pre-pull complete"

.github/workflows/unit-tests-internal.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ jobs:
9595
pull clickhouse/clickhouse-server:26.2.19.43-alpine@sha256:c6ad6a7eb2fb5999df3adfb8b69a0c7222c68fa9b8f6b04a088564ebbc959251
9696
pull redis:7.2
9797
pull testcontainers/ryuk:0.14.0
98-
pull electricsql/electric:1.2.4
9998
echo "Image pre-pull complete"
10099
101100
- name: 📥 Download deps

.github/workflows/unit-tests-packages.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ jobs:
9797
pull clickhouse/clickhouse-server:26.2.19.43-alpine@sha256:c6ad6a7eb2fb5999df3adfb8b69a0c7222c68fa9b8f6b04a088564ebbc959251
9898
pull redis:7.2
9999
pull testcontainers/ryuk:0.14.0
100-
pull electricsql/electric:1.2.4
101100
pull otel/opentelemetry-collector-k8s:0.158.0@sha256:c09130a633196a5becee164411473a0932ecf223f94fda6dab5f22798ff9f376
102101
echo "Image pre-pull complete"
103102

.github/workflows/unit-tests-webapp.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,10 +99,11 @@ jobs:
9999
}
100100
echo "Pre-pulling Docker images with authenticated session..."
101101
pull postgres:14
102+
pull postgres:17
102103
pull clickhouse/clickhouse-server:26.2.19.43-alpine@sha256:c6ad6a7eb2fb5999df3adfb8b69a0c7222c68fa9b8f6b04a088564ebbc959251
103104
pull redis:7.2
104105
pull testcontainers/ryuk:0.14.0
105-
pull electricsql/electric:1.2.4
106+
pull electricsql/electric:1.2.4@sha256:20da3d0b0e74926c5623392db67fd56698b9e374c4aeb6cb5cadeb8fea171c36
106107
pull minio/minio:latest
107108
echo "Image pre-pull complete"
108109

0 commit comments

Comments
 (0)