From c8b146444d47040a5f469ef28408af3577183d3f Mon Sep 17 00:00:00 2001 From: Adrian Webb Date: Sun, 11 Oct 2026 23:05:10 -0400 Subject: [PATCH 1/2] test(acceptance): reproduce missing generated-review readiness binding --- tests/modern/guarantees/bindings.test.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/modern/guarantees/bindings.test.ts b/tests/modern/guarantees/bindings.test.ts index b4c8c41c..5f03fd92 100644 --- a/tests/modern/guarantees/bindings.test.ts +++ b/tests/modern/guarantees/bindings.test.ts @@ -116,6 +116,8 @@ describe('capacity-provider guarantee execution bindings', () => { .toEqual([{ criterion: '6d6749cd8c2676c6c50c009b55025ec3b951589db602440f63b76ba021159f20', verifierRefs: ['agent.golden.live.graph', product] }]); expect(refs.filter(value => value === 'agent.golden.live.graph')).toHaveLength(1); const reviewed = 'agent.golden.architecture-living-graph-live-1'; + expect(manifest.acceptanceCriteria.filter((value: { criterion: string }) => value.criterion === '614467b937b7b271b37e1e7b484adba4d65cf486993d9273807130dcc351f69e')) + .toEqual([{ criterion: '614467b937b7b271b37e1e7b484adba4d65cf486993d9273807130dcc351f69e', verifierRefs: [product, reviewed] }]); expect(manifest.acceptanceCriteria.filter((value: { criterion: string }) => value.criterion === '697358e950cb89fc5928569468cd955c25daa8fda7ff97fd1a4af35e2eb95fc6')) .toEqual([{ criterion: '697358e950cb89fc5928569468cd955c25daa8fda7ff97fd1a4af35e2eb95fc6', verifierRefs: ['agent.golden.live.graph', reviewed] }]); expect(refs.filter(value => value === reviewed)).toHaveLength(1); From b8f9697cbcc138dff2ddb81364bfd06d23d0eebb Mon Sep 17 00:00:00 2001 From: Adrian Webb Date: Sun, 11 Oct 2026 23:06:09 -0400 Subject: [PATCH 2/2] fix(acceptance): bind generated review readiness to original native gates --- guarantees/agent/golden/sdk-complete.guarantee.yaml | 2 ++ tests/modern/guarantees/bindings.test.ts | 1 + 2 files changed, 3 insertions(+) diff --git a/guarantees/agent/golden/sdk-complete.guarantee.yaml b/guarantees/agent/golden/sdk-complete.guarantee.yaml index ed216016..4138f524 100644 --- a/guarantees/agent/golden/sdk-complete.guarantee.yaml +++ b/guarantees/agent/golden/sdk-complete.guarantee.yaml @@ -11,6 +11,8 @@ scene: required: true manifest: guarantees/agent/golden/scenes/sdk-complete.scene.yaml acceptanceCriteria: + - criterion: 614467b937b7b271b37e1e7b484adba4d65cf486993d9273807130dcc351f69e + verifierRefs: [sdk.golden.live.product, agent.golden.architecture-living-graph-live-1] - criterion: 8ef82a4f4cb2b8e93d060e38cf8758944d2ba54baca44787811a1d76683f99d4 verifierRefs: [agent.golden.live.campaign-freeze] - criterion: 2feaea9a8a706e1279affead3af5bacc467f12b285ba2570f183361c5d8203c7 diff --git a/tests/modern/guarantees/bindings.test.ts b/tests/modern/guarantees/bindings.test.ts index 5f03fd92..0f0f9f63 100644 --- a/tests/modern/guarantees/bindings.test.ts +++ b/tests/modern/guarantees/bindings.test.ts @@ -197,6 +197,7 @@ describe('capacity-provider guarantee execution bindings', () => { 'b918b519ac545fdd61faab208687ccc64e1f3d03c9a84dfc57a5cfee6190f3f3', ].map(criterion => ({ criterion, verifierRefs: ['agent.golden.live.campaign-freeze'] })); expect(manifest.acceptanceCriteria).toEqual([ + { criterion: '614467b937b7b271b37e1e7b484adba4d65cf486993d9273807130dcc351f69e', verifierRefs: ['sdk.golden.live.product', 'agent.golden.architecture-living-graph-live-1'] }, { criterion: '8ef82a4f4cb2b8e93d060e38cf8758944d2ba54baca44787811a1d76683f99d4', verifierRefs: ['agent.golden.live.campaign-freeze'] }, { criterion: '2feaea9a8a706e1279affead3af5bacc467f12b285ba2570f183361c5d8203c7', verifierRefs: ['agent.golden.live.campaign-freeze', 'agent.golden.live.campaign'] }, { criterion: '64ffc06b0d268ad11fbf692ca201cd75423c0afae2a6be3e2ae7cd2eea7fb17f', verifierRefs: ['agent.golden.live.campaign', 'api.golden.execution-normal-sdk-clean-schema-live-1', 'agent.golden.architecture-record-custody-live-1', 'agent.golden.architecture-living-graph-live-1'] },