Skip to content

Missign injectable in directive with Classes #153

Description

@bastienmoulia

Following https://github.com/toddmotto/angular-styleguide/blob/master/README.md#constants-or-classes

When i want to use a Class in directives I think the injectable should be added to the module:

export const TodoModule = angular
  .module('todo', [])
  .component('todo', TodoComponent)
  .directive('todoAutofocus', () => new TodoAutoFocus())
  .name;

must be

export const TodoModule = angular
  .module('todo', [])
  .component('todo', TodoComponent)
  .directive('todoAutofocus', ['$timeout', ($timeout) => new TodoAutoFocus($timeout)])
  .name;

to avoid the message error TS2346: Supplied parameters do not match any signature of call target.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions