Road to Throne #525
Locked
parhelia512
started this conversation in
Development
Road to Throne
#525
Replies: 85 comments 108 replies
|
Currently I am preparing the new icon/tray images. Then I need to rename some internal code stuff, preferably removing the word |
0 replies
|
I have created "1.0" milestone https://github.com/throneproj/nekoray/milestone/1. |
0 replies
|
I will add legacy windows support to the main repository next week. |
0 replies
|
@Mahdi-zarei I refactored the code of core. Convert core server to a shared library. |
0 replies
|
Export symbols: |
0 replies
|
Useage: Here is a modified version of |
0 replies
|
Windows build nekoray.zip. |
0 replies
|
I once thought about having the core as a lib, like Libbox that SFA uses, but there are several issues that make it hard. First thing is that we lose the ability to hard restart the core, as it no longer is a process you could simply kill or restart. Another is that on Linux you cannot set the system proxy when running as the root user, but you need root access for Tun mode. Third is actually there are lots of system Calls in the sing-box and I am kinda worried that not all of them will work properly when compiled to c code. So I guess it is best to keep the core a separate process to ensure things will remain safe and also have more control over it as a separate process. |
0 replies
|
There also seems to be a weird bug with the simple-protobuf library, #534, in this issue, from the second call onwards, the |
0 replies
|
I fixed the issue with spb. There is also another thing that makes it not worth making the core a clib, and that is its crashes will cause the whole app to crash, we can of course add a recover to the main function but it really isn't a solution. So my final thought is that even though it is amazing to have a single binary to distribute, the amount of problems and complexities is simply too much and it is not a good idea to do it. |
0 replies
|
@Mahdi-zarei Thank you so much for your detailed explanation. I will stop further research on it. |
0 replies
|
Regarding simple protobuf, there are issues with default values as having fields set as required makes api calls cumbersome as we cant leave them empty, and having them set as optional will require a |
0 replies
|
Setting a default value for a required field(like fd421d0) works or not? |
0 replies
|
It does work in the context of the value you read from it, but the problem is if you don't provide that field, the rpc will fail. Setting it as optional causes the code to break and we need to make significant changes. |
0 replies
|
https://github.com/throneproj/nekoray/tree/refs/heads/optional_field |
0 replies
|
Multi-column filter feature has been merged. It is disabled by default. Users can enable/disable filter by pressing filter.mp4 |
1 reply
|
It works great! Let me add warp support and then we can release 1.1.0 . |
|
I guess we should release the stable version now, do you know of any bugs we have to fix before doing it? |
7 replies
|
We can't always refresh the column width, it lags the app when the group is too large. We need to improve our detection on when it needs it. Also drag and drop of files seem to be broken due to Qt upgrade, I need to fix it too. There are some issues with wireguard too that i suspect it might be due to golang upgrade, should check that out as well. |
|
Understood! |
|
Ok seems like wireguard's problem was with golang 1.26 and now it works. The issue with drag and drop is due to windows security issues and only happens when Throne is admin. |
https://github.com/throneproj/Throne/actions/runs/22691006719 |
|
@Mahdi-zarei I added support for Juicity, TrustTunnel, ShadowTLS protocols to the |
3 replies
|
I feel it is best to keep it for 1.1.1, lets just fix up our issues and release the stable version first. But it's great to have them! We may also be able to add support for some other protocols via extra core (built in support based on our current extra core implementation) |
|
Okay! It will be merged after releasing v1.1.0. |
|
Support for Juicity, TrustTunnel, ShadowTLS protocols has been merged. |
|
@Mahdi-zarei The upstream sing-box repository creates |
1 reply
|
Yes we should also rename our branches to match the upstream for easier upgrades. |
|
@Mahdi-zarei With so many improvements and fixes in place, I think we're ready for a new version. |
1 reply
|
A few small things are left, I will add them and we will release. |
|
I have added support for chaining Xray configs (sing->xray->sing at most, cannot transition between cores more than that) |
5 replies
|
xray->sing and xray with warp work perfactly. |
|
Can you give me a public Xray subscription please (some of its configs should work so that i can test with them)? |
|
It looks weird. if i chain the config you sent me into itself, it fails, but from what i can see the config that is generated looks correct. The case where Xray chains into sing-box also fails as you said, which makes me to believe maybe there is an issue with Xray chaining... |
|
https://github.com/throneproj/Throne/actions/runs/24900911984 fixes it |
|
It works! |
|
I made some changes to secure the access between core and gui given that we have suid which is dangerous. Please give it a bit of testing, since we migrated from tcp to unix socket/named pipes. |
6 replies
|
After further testing, the issue of the program randomly exiting is present in https://github.com/throneproj/Throne/actions/runs/25877806195. Reproduce on windows:
|
|
Crashing randomly on macOS 10.15.7 |
|
Seems like a race condition. |
|
Fantastic! Tested it out and it’s stable now. |
|
@Mahdi-zarei please review #1446 and #1447 when you have time 🙂 |
0 replies
|
Are there any issues you think we should work upon before release? I have tested the new version myself and it seems to be stable so far. |
1 reply
|
The new version is stable, and I haven't found any functional issues. |
|
@Mahdi-zarei 29d9420 broke the |
1 reply
|
I was trying to prepare things for releasing throne in package managers, but did not find the time to keep at it. Feel free to revert that commit. |
|
@Mahdi-zarei I'm back after finishing up the mid-year rush. |
2 replies
|
Welcome back! I reverted the commit now. |
|
By the way, if you are interested, you can add your github sponsors to the FUNDING.yml so that it gets shown in the repo's main page. |
|
@Mahdi-zarei I updated deep-link schemes. Please review #1655. Action https://github.com/throneproj/Throne/actions/runs/29692390084.
|
3 replies
|
I'll update |
|
The changes can work for now, but they will cause us to lose flexibility in adding new items to the links in the future, since we now already include the data and do not allow custom fields. I think keeping the query params can help us later, or defining a json schema that gets B64-ed, this way adding fields will not break the format, and it becomes backward compatible. |
|
|
|
I'm quite eager to release 1.2.0 stable asap, since there are already LOTS of changes. If you have not found any bugs or any user has not reported any, we can release as soon as possible and keep further changes for the next release. |
7 replies
|
Okay, that's enough. |
|
I will add them soon. |
|
I think we are ready now |
|
One more thing, it would be better to move |
|
Makes sense |
|
@Mahdi-zarei The new version of the website is live. https://throneproj.github.io/ |
1 reply
|
Looks great! |
|
I made some changes to throneProj's base member accesses and gave you maintainer access to all repos, should be fine, but if you faced any issues, let me know to fix it. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Leave your thoughts about Throne here.
All reactions