From 4c19a11001160ad224d005a0fd7016779d7ee7bb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A1lmi=20=C3=9E=C3=B3r=20Valgeirsson?= Date: Tue, 11 Aug 2026 13:50:16 +0000 Subject: [PATCH] fix: preview cleanup queue deletion and update actions to node24 wrangler queues delete does not support --force, causing preview cleanup to fail on queue deletion. Remove the invalid flag. Update GitHub Actions that target deprecated Node 20 (setup-bun, wrangler-action, github-script, caching-for-turbo) to node24 versions to eliminate deprecation warnings. --- .github/workflows/ci.yml | 6 +++--- .github/workflows/e2e.yml | 4 ++-- .github/workflows/preview.yml | 12 ++++++------ scripts/lib/cleanup.ts | 2 +- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d36b1f92..51bb8117 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,7 +17,7 @@ jobs: fetch-depth: 0 - name: 🥟 Setup Bun - uses: oven-sh/setup-bun@735343b667d3e6f658f44d0eca948eb6282f2b76 # v2.0.2 + uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0 with: bun-version: latest @@ -25,7 +25,7 @@ jobs: run: bun install - name: ⚡ Setup Turbo cache - uses: rharkor/caching-for-turbo@cda201ff2b32699a2ae9f59704db029e3dde4fbd + uses: rharkor/caching-for-turbo@2238fae6eb9a9936f92356f54cb3660200d105e7 # v2.5.1 - name: 💅 Format check run: bun run format @@ -54,7 +54,7 @@ jobs: CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }} - name: Build & Deploy Worker - uses: cloudflare/wrangler-action@da0e0dfe58b7a431659754fdf3f186c529afbe65 # v3.14.1 + uses: cloudflare/wrangler-action@ebbaa1584979971c8614a24965b4405ff95890e0 # v4.0.0 if: github.ref == 'refs/heads/main' with: apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }} diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 12fd0ed6..aebf0d52 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -22,7 +22,7 @@ jobs: fetch-depth: 0 - name: 🥟 Setup Bun - uses: oven-sh/setup-bun@735343b667d3e6f658f44d0eca948eb6282f2b76 # v2.0.2 + uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0 with: bun-version: latest @@ -30,7 +30,7 @@ jobs: run: bun install - name: ⚡ Setup Turbo cache - uses: rharkor/caching-for-turbo@cda201ff2b32699a2ae9f59704db029e3dde4fbd + uses: rharkor/caching-for-turbo@2238fae6eb9a9936f92356f54cb3660200d105e7 # v2.5.1 - name: 🎭 Install Playwright run: bunx playwright install chromium --with-deps diff --git a/.github/workflows/preview.yml b/.github/workflows/preview.yml index 983484f0..57feeb9a 100644 --- a/.github/workflows/preview.yml +++ b/.github/workflows/preview.yml @@ -16,7 +16,7 @@ jobs: uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 #v5.0.0 - name: 🥟 Setup Bun - uses: oven-sh/setup-bun@735343b667d3e6f658f44d0eca948eb6282f2b76 # v2.0.2 + uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0 with: bun-version: latest @@ -100,7 +100,7 @@ jobs: CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }} - name: 🚀 Deploy to Cloudflare Workers - uses: cloudflare/wrangler-action@v3 + uses: cloudflare/wrangler-action@ebbaa1584979971c8614a24965b4405ff95890e0 # v4.0.0 id: deploy with: apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }} @@ -114,7 +114,7 @@ jobs: echo "preview_url=$PREVIEW_URL" >> $GITHUB_OUTPUT - name: 💬 Comment on PR - uses: actions/github-script@v7 + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0 with: script: | const prNumber = context.issue.number; @@ -176,7 +176,7 @@ jobs: uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 #v5.0.0 - name: 🥟 Setup Bun - uses: oven-sh/setup-bun@735343b667d3e6f658f44d0eca948eb6282f2b76 # v2.0.2 + uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2.2.0 with: bun-version: latest @@ -192,7 +192,7 @@ jobs: CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }} - name: 🗑️ Delete Worker - uses: cloudflare/wrangler-action@v3 + uses: cloudflare/wrangler-action@ebbaa1584979971c8614a24965b4405ff95890e0 # v4.0.0 continue-on-error: true with: apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }} @@ -224,7 +224,7 @@ jobs: CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }} - name: 💬 Comment on PR - uses: actions/github-script@v7 + uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0 with: script: | const prNumber = context.issue.number; diff --git a/scripts/lib/cleanup.ts b/scripts/lib/cleanup.ts index 2d603762..05e538bc 100644 --- a/scripts/lib/cleanup.ts +++ b/scripts/lib/cleanup.ts @@ -261,7 +261,7 @@ export async function deleteQueue(queueName: string): Promise { if (queueExists) { debug(`Deleting queue ${queueName}...`); - const cmd = $`bun wrangler queues delete ${queueName} --force`; + const cmd = $`bun wrangler queues delete ${queueName}`; if (!debugMode) { cmd.quiet(); }