onLayout can be triggered multiple times and break the calculation logic

[anthlasserre]

Hey @thinhkhang97 👋🏼
Me again 😅

By using your library I have faced an issue on the checkInViewPort calculation.

The View set in the ViewPortDetectorProvider can trigger multiple times the onLayout callback depending on what your children contain.

I was thinking about to apply a default delay to enable the checkInViewPort call.

What are your thoughts?

I'm about to raise a PR with this suggestion

[thinhkhang97]

That's a good catch @anthlasserre . But adding a default delay to enable the checkInViewPort call is not a long run solution, because of the time to completely render the children components is not only depending on the complexity of the components but also the network, device situation. So we don't know exactly the perfect time to trigger the callback.

For more usable, I think we should have a prop like startMeasuring?: boolean, the component will trigger that prop when it ready to measure the position, like after fetching data, after render completely, etc... What do you think about that?

[anthlasserre]

Ah yeah, it makes more sense to do it in that way. Thanks @thinhkhang97 🙏🏼 I'll update my PR

[anthlasserre]

All updated @thinhkhang97 🔄