style(testng): stop spelling out imports the compiler can resolve

SuiteResult compared two possibly-absent <test> names by writing out both
java.util.Objects.compare and java.util.Comparator.nullsFirst on one line, where
neither name clashes with anything the file imports. The comparator is now a
named constant that says what the order is -- an unnamed <test> sorts first --
and the call site is one short expression.

ClassImpl and TestResult keep java.util.Objects out of their bodies with a static
import of requireNonNull. Both files import org.testng.collections.Objects for
toStringHelper, which is what forced the qualified form; the repo already static
imports JDK members this way (StandardCharsets.UTF_8) and its own helpers
(Utils.isStringNotEmpty, ListenerComparator.sort).

MethodInstance keeps the one qualified java.util.Objects.equals it has:
org.testng.collections.Objects offers no equals, and a bare static-imported
equals(a, b) inside a class reads like this.equals.

testng-core's dependency block also loses the comment about annotations needing
to be on the compile classpath. It explained the spotbugs compileOnly that went
with the last javax.annotation uses, and described nothing once that left.

Author: juherr

testng-core/src/main/java/org/testng/SuiteResult.java

@@ -1,11 +1,16 @@
 package org.testng;
 
+import java.util.Comparator;
 import org.testng.collections.Objects;
 import org.testng.log4testng.Logger;
 import org.testng.xml.XmlSuite;
 
 /** This class logs the result of an entire Test Suite (defined by a property file). */
 class SuiteResult implements ISuiteResult, Comparable<SuiteResult> {
+
+  /** A &lt;test&gt; that carries no name sorts ahead of the ones that do. */
+  private static final Comparator<String> NAME_ORDER = Comparator.nullsFirst(String::compareTo);
+
   private final XmlSuite m_suite;
   private final ITestContext m_testContext;
 
@@ -30,8 +35,7 @@ public int compareTo(SuiteResult other) {
     try {
       String n1 = getTestContext().getName();
       String n2 = other.getTestContext().getName();
-      result =
-          java.util.Objects.compare(n1, n2, java.util.Comparator.nullsFirst(String::compareTo));
+      result = NAME_ORDER.compare(n1, n2);
     } catch (Exception ex) {
       Logger.getLogger(SuiteResult.class).error(ex.getMessage(), ex);
     }

testng-core/src/main/java/org/testng/internal/ClassImpl.java

@@ -1,5 +1,7 @@
 package org.testng.internal;
 
+import static java.util.Objects.requireNonNull;
+
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
@@ -104,8 +106,7 @@ public XmlTest getXmlTest() {
           factory = m_testContext.getSuite().getObjectFactory();
         }
         IObjectDispenser dispenser =
-            Dispenser.newInstance(
-                java.util.Objects.requireNonNull(factory, "a suite carries an object factory"));
+            Dispenser.newInstance(requireNonNull(factory, "a suite carries an object factory"));
         BasicAttributes basic = new BasicAttributes(this, null);
         DetailedAttributes detailed = newDetailedAttributes(create, errMsgPrefix);
         CreationAttributes attributes = new CreationAttributes(m_testContext, basic, detailed);
@@ -174,7 +175,7 @@ private static int computeHashCode(IdentifiableObject identifiable) {
       // derive a stable one from its unique instance id instead.
       return identifiable.getInstanceId().hashCode();
     }
-    return java.util.Objects.requireNonNull(
+    return requireNonNull(
             IParameterInfo.embeddedInstance(instance), "the factory instance is not available")
         .hashCode();
   }

testng-core/testng-core-build.gradle.kts

@@ -21,7 +21,6 @@ tasks.withType<GroovyCompile>().configureEach {
 
 dependencies {
     api(projects.testngCoreApi)
-    // Annotations have to be available on the compile classpath for the proper compilation
 
     "guiceApi"(platform("com.google.inject:guice-bom:6.0.0"))
     "guiceApi"("com.google.inject:guice")

testng-runner-api/src/main/java/org/testng/internal/TestResult.java

@@ -1,5 +1,7 @@
 package org.testng.internal;
 
+import static java.util.Objects.requireNonNull;
+
 import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
 import java.util.ArrayList;
@@ -195,7 +197,7 @@ public void setEndMillis(long millis) {
    * builds a carrier that has no method, and those members are not reachable on it.
    */
   private ITestNGMethod requireMethod() {
-    return java.util.Objects.requireNonNull(
+    return requireNonNull(
         m_method, "This TestResult carries parameters only; it has no test method");
   }