libalgebra/vectors/vector.h lines 96-97 define mone and one; should these objects be declared elsewhere? vectors don't have a multiplication - not all the algebras considered in libalgebra have a unit (LIE for example). However the basic graded tensor algebras do. If these vector classes are specific to the graded tensor case, and have specific marked basis elements etc., maybe one should change the class name from vector?
using UnderlyingVectorType::mone; using UnderlyingVectorType::one;
libalgebra/vectors/vector.h lines 96-97 define mone and one; should these objects be declared elsewhere? vectors don't have a multiplication - not all the algebras considered in libalgebra have a unit (LIE for example). However the basic graded tensor algebras do. If these vector classes are specific to the graded tensor case, and have specific marked basis elements etc., maybe one should change the class name from vector?
using UnderlyingVectorType::mone; using UnderlyingVectorType::one;