Skip to content

Commit dfe2627

Browse files
Craigacpkarllessard
authored andcommitted
Working on bazel protobuf generation.
1 parent ff33b16 commit dfe2627

6 files changed

Lines changed: 28 additions & 43 deletions

File tree

tensorflow-core/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/workspace2.bzl
4343
(but for the currently used release, not master)
4444
-->
45-
<protobuf.version>3.21.9</protobuf.version>
45+
<protobuf.version>4.28.3</protobuf.version>
4646

4747
<native.classifier>${javacpp.platform}${javacpp.platform.extension}</native.classifier>
4848
<javacpp.platform.extension></javacpp.platform.extension>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
7.7.0
1+
7.4.1
22
# NOTE: Update Bazel version in tensorflow/tools/ci_build/release/common.sh.oss

tensorflow-core/tensorflow-core-native/BUILD

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ java_proto_library(
44
name = "java_proto_gen_sources",
55
deps = [
66
"@org_tensorflow//tensorflow/core:protos_all",
7-
"@local_xla//xla/tsl/protobuf:bfc_memory_map_proto",
8-
"@local_xla//xla/tsl/protobuf:test_log_proto",
9-
"@local_tsl//tsl/protobuf:protos_all"
7+
"@local_xla//xla/tsl/protobuf:protos_all"
108
]
119
)

tensorflow-core/tensorflow-core-native/WORKSPACE

Lines changed: 19 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -37,15 +37,6 @@ http_archive(
3737
url = "https://github.com/bazelbuild/rules_shell/releases/download/v0.4.1/rules_shell-v0.4.1.tar.gz",
3838
)
3939

40-
# We must initialize hermetic python first.
41-
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
42-
43-
http_archive(
44-
name = "rules_java",
45-
sha256 = "c73336802d0b4882e40770666ad055212df4ea62cfa6edf9cb0f9d29828a0934",
46-
url = "https://github.com/bazelbuild/rules_java/releases/download/5.3.5/rules_java-5.3.5.tar.gz",
47-
)
48-
4940
# Initialize the TensorFlow repository and all dependencies.
5041
#
5142
# The cascade of load() statements and tf_workspace?() calls works around the
@@ -76,7 +67,7 @@ python_init_repositories(
7667
"tensorflow*",
7768
"tf_nightly*",
7869
],
79-
local_wheel_workspaces = ["//:WORKSPACE"],
70+
local_wheel_workspaces = ["@org_tensorflow//:WORKSPACE"],
8071
requirements = {
8172
"3.9": "@org_tensorflow//:requirements_lock_3_9.txt",
8273
"3.10": "@org_tensorflow//:requirements_lock_3_10.txt",
@@ -113,32 +104,11 @@ tf_workspace0()
113104

114105
load(
115106
"@local_xla//third_party/py:python_wheel.bzl",
116-
"nvidia_wheel_versions_repository",
117107
"python_wheel_version_suffix_repository",
118108
)
119109

120-
nvidia_wheel_versions_repository(
121-
name = "nvidia_wheel_versions",
122-
versions_source = "//ci/official/requirements_updater:nvidia-requirements.txt",
123-
)
124-
125110
python_wheel_version_suffix_repository(name = "tf_wheel_version_suffix")
126111

127-
load(
128-
"@rules_ml_toolchain//cc/deps:cc_toolchain_deps.bzl",
129-
"cc_toolchain_deps",
130-
)
131-
132-
cc_toolchain_deps()
133-
134-
register_toolchains("@rules_ml_toolchain//cc:linux_x86_64_linux_x86_64")
135-
136-
register_toolchains("@rules_ml_toolchain//cc:linux_x86_64_linux_x86_64_cuda")
137-
138-
register_toolchains("@rules_ml_toolchain//cc:linux_aarch64_linux_aarch64")
139-
140-
register_toolchains("@rules_ml_toolchain//cc:linux_aarch64_linux_aarch64_cuda")
141-
142112
load(
143113
"@rules_ml_toolchain//third_party/gpus/cuda/hermetic:cuda_json_init_repository.bzl",
144114
"cuda_json_init_repository",
@@ -205,3 +175,21 @@ load(
205175
nvshmem_redist_init_repository(
206176
nvshmem_redistributions = NVSHMEM_REDISTRIBUTIONS,
207177
)
178+
179+
load(
180+
"@rules_ml_toolchain//third_party/nvshmem/hermetic:nvshmem_configure.bzl",
181+
"nvshmem_configure",
182+
)
183+
184+
nvshmem_configure(name = "local_config_nvshmem")
185+
186+
load(
187+
"@rules_ml_toolchain//cc_toolchain/deps:cc_toolchain_deps.bzl",
188+
"cc_toolchain_deps",
189+
)
190+
191+
cc_toolchain_deps()
192+
193+
register_toolchains("@rules_ml_toolchain//cc_toolchain:lx64_lx64")
194+
195+
register_toolchains("@rules_ml_toolchain//cc_toolchain:lx64_lx64_cuda")

tensorflow-core/tensorflow-core-native/scripts/bazel_common.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
set -eu
33

44
# Set generic Bazel build options
5-
export BAZEL_USE_CPP_ONLY_TOOLCHAIN=1
65
export BAZEL_VC="${VCINSTALLDIR:-}"
76
if [[ -d $BAZEL_VC ]]; then
87
export BUILD_FLAGS="--output_user_root=$(cygpath -w $TMP) build"
@@ -16,7 +15,7 @@ fi
1615
if [[ "${PLATFORM:-}" == macosx-arm64 ]]; then
1716
BUILD_FLAGS="$BUILD_FLAGS --config=macos_arm64"
1817
fi
19-
BUILD_FLAGS="$BUILD_FLAGS --experimental_repo_remote_exec --python_path="$PYTHON_BIN_PATH" --output_filter=DONT_MATCH_ANYTHING --verbose_failures --distinct_host_configuration=true"
18+
BUILD_FLAGS="$BUILD_FLAGS --experimental_repo_remote_exec --python_path="$PYTHON_BIN_PATH" --output_filter=DONT_MATCH_ANYTHING --verbose_failures"
2019

2120
export BAZEL_BIN=$(pwd -P)/bazel-bin
2221
export TENSORFLOW_BIN=$BAZEL_BIN/external/org_tensorflow/tensorflow

tensorflow-core/tensorflow-core-native/tensorflow.bazelrc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ build:apple-toolchain --host_crosstool_top=@local_config_apple_cc//:toolchain
222222
# Settings for MacOS on ARM CPUs.
223223
build:macos_arm64 --cpu=darwin_arm64
224224
build:macos_arm64 --macos_minimum_os=11.0
225-
build:macos_arm64 --platforms=@build_bazel_apple_support//configs/platforms:darwin_arm64
225+
build:macos_arm64 --platforms=@build_bazel_apple_support//platforms:darwin_arm64
226226

227227
# iOS configs for each architecture and the fat binary builds.
228228
build:ios --apple_platform_type=ios
@@ -234,16 +234,16 @@ build:ios_armv7 --cpu=ios_armv7
234234
build:ios_armv7 --platforms=@org_tensorflow//tensorflow/tools/toolchains/ios:ios_armv7
235235
build:ios_arm64 --config=ios
236236
build:ios_arm64 --cpu=ios_arm64
237-
build:ios_arm64 --platforms=@build_bazel_apple_support//configs/platforms:ios_arm64
237+
build:ios_arm64 --platforms=@build_bazel_apple_support//platforms:ios_arm64
238238
build:ios_arm64e --config=ios
239239
build:ios_arm64e --cpu=ios_arm64e
240-
build:ios_arm64e --platforms=@build_bazel_apple_support//configs/platforms:ios_arm64e
240+
build:ios_arm64e --platforms=@build_bazel_apple_support//platforms:ios_arm64e
241241
build:ios_sim_arm64 --config=ios
242242
build:ios_sim_arm64 --cpu=ios_sim_arm64
243-
build:ios_sim_arm64 --platforms=@build_bazel_apple_support//configs/platforms:ios_sim_arm64
243+
build:ios_sim_arm64 --platforms=@build_bazel_apple_support//platforms:ios_sim_arm64
244244
build:ios_x86_64 --config=ios
245245
build:ios_x86_64 --cpu=ios_x86_64
246-
build:ios_x86_64 --platforms=@build_bazel_apple_support//configs/platforms:ios_x86_64
246+
build:ios_x86_64 --platforms=@build_bazel_apple_support//platforms:ios_x86_64
247247
build:ios_fat --config=ios
248248
build:ios_fat --ios_multi_cpus=armv7,arm64,i386,x86_64
249249

0 commit comments

Comments
 (0)