Skip to content

Unexpected tied notes when using Crow/What is note length supposed to do? #11

Description

@simonvanderveldt

I noticed that when using Awake with crow that notes "next" to each other don't trigger. They become tied notes.

Initially I thought this might be because the note length was set to 100% (I could see 100% note length meaning tied notes) but changing it doesn't make a difference. Looking at the code it seems like there's a metro that's responsible for note off events which calls a function to turn off notes but it only include this functionality for MIDI (see https://github.com/tehn/awake/blob/master/awake.lua#L138) and not for crow.

I made a dumb fix by adding the following on this line.

  elseif params:get("output") == 4 then
    crow.output[2].volts = 0

And by replacing this line with

crow.output[2].volts = 5

This works, but oddly enough changing the step length doesn't seem to influence the duration of the high "pulse". Not really sure why.
And I guess it might be better to use the pulse action on crow? We'll need to changing it's duration to match the note length somehow in that case though.
Also because the all_notes_off function always gets called there's no way to get tied notes when using MIDI.

What is the desired behavior? And how we can fix the current implementation to get that behavior?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions