Adapt to PatternFX changes (remove HistoryPolicy)

Author: pcastornii

shellfx-core/src/main/java/com/techsenger/shellfx/core/DefaultShellParams.java

@@ -16,7 +16,6 @@
 
 package com.techsenger.shellfx.core;
 
-import com.techsenger.patternfx.core.HistoryPolicy;
 import com.techsenger.shellfx.core.window.WindowParams;
 import com.techsenger.shellfx.core.window.WindowType;
 import java.util.Objects;
@@ -32,7 +31,6 @@ public class DefaultShellParams extends WindowParams {
     public DefaultShellParams(ShellContext context) {
         super(WindowType.TOP_LEVEL, false, context.getSettings().getAppearance());
         this.context = context;
-        setHistoryPolicy(HistoryPolicy.APPEARANCE);
         setHistoryProvider(() -> context.getHistoryManager().getOrCreateHistory(ShellHistory.class, ShellHistory::new));
     }
 

shellfx-core/src/main/java/com/techsenger/shellfx/core/DefaultShellPresenter.java

@@ -71,8 +71,8 @@ protected ComponentDescriptor createDescriptor() {
     }
 
     @Override
-    protected void applyAppearance() {
-        super.applyAppearance();
+    protected void applyPersistentState() {
+        super.applyPersistentState();
         setWidth(1200);
         setHeight(800);
     }

shellfx-core/src/main/java/com/techsenger/shellfx/core/dialog/AbstractDialogPresenter.java

@@ -151,8 +151,8 @@ protected DialogHistory getHistory() {
     }
 
     @Override
-    protected void restoreAppearance() {
-        super.restoreAppearance();
+    protected void restorePersistentState() {
+        super.restorePersistentState();
         var h = getHistory();
         setWidth(h.getWidth());
         setHeight(h.getHeight());
@@ -165,8 +165,8 @@ protected void onResult(ResultButtonName name) {
     }
 
     @Override
-    protected void saveAppearance() {
-        super.saveAppearance();
+    protected void savePersistentState() {
+        super.savePersistentState();
         var h = getHistory();
         h.setWidth(getWidth());
         h.setHeight(getHeight());

shellfx-core/src/main/java/com/techsenger/shellfx/core/window/AbstractWindowPresenter.java

@@ -465,17 +465,17 @@ protected WindowHistory getHistory() {
     }
 
     @Override
-    protected void restoreAppearance() {
-        super.restoreAppearance();
+    protected void restorePersistentState() {
+        super.restorePersistentState();
         var h = getHistory();
         setMaximized(h.isMaximized());
         setHeight(h.getHeight());
         setWidth(h.getWidth());
     }
 
     @Override
-    protected void saveAppearance() {
-        super.saveAppearance();
+    protected void savePersistentState() {
+        super.savePersistentState();
         var h = getHistory();
         h.setWidth(getWidth());
         h.setHeight(getHeight());

shellfx-demo/src/main/java/com/techsenger/shellfx/demo/HostFactory.java

@@ -16,7 +16,6 @@
 
 package com.techsenger.shellfx.demo;
 
-import com.techsenger.patternfx.core.HistoryPolicy;
 import com.techsenger.patternfx.core.HistoryProvider;
 import com.techsenger.shellfx.core.ShellFxView;
 import com.techsenger.shellfx.core.area.AreaParams;
@@ -41,7 +40,6 @@ public final class HostFactory {
     public static TabHostFxView<?> createTabHost() {
         var view = new TabHostFxView<>(true);
         var params = new AreaParams();
-        params.setHistoryPolicy(HistoryPolicy.NONE);
         var presenter = new TabHostPresenter<>(view, params);
         presenter.initialize();
         return view;
@@ -67,7 +65,6 @@ protected DockHostFxView.Composer createComposer() {
             }
         };
         var params = new DockHostParams(historyProvider);
-        params.setHistoryPolicy(HistoryPolicy.NONE);
         var presenter = new DockHostPresenter<>(view, params);
         presenter.initialize();
         view.getComposer().setBottomBarPolicy(SideBarPolicy.EXISTS_ALWAYS);

shellfx-demo/src/main/java/com/techsenger/shellfx/demo/browser/BrowserMainTabParams.java

@@ -16,7 +16,6 @@
 
 package com.techsenger.shellfx.demo.browser;
 
-import com.techsenger.patternfx.core.HistoryPolicy;
 import com.techsenger.shellfx.core.history.HistoryManager;
 import com.techsenger.shellfx.core.tab.HostTabParams;
 import java.util.Objects;
@@ -31,7 +30,6 @@ public class BrowserMainTabParams extends HostTabParams {
 
     public BrowserMainTabParams(HistoryManager historyManager) {
         this.historyManager = historyManager;
-        setHistoryPolicy(HistoryPolicy.ALL);
         setHistoryProvider(() -> historyManager
                 .getOrCreateHistory(BrowserMainTabHistory.class, BrowserMainTabHistory::new));
     }

shellfx-demo/src/main/java/com/techsenger/shellfx/demo/dialogs/DemoDialogPresenter.java

@@ -56,12 +56,4 @@ protected void postInitialize() {
         setTitle("Demo Dialog");
         setRightButtons(DemoResultButtons.CANCEL, DemoResultButtons.OK);
     }
-
-    @Override
-    protected void applyAppearance() {
-        super.applyAppearance();
-        //setWidth(500);
-    }
-
-
 }

shellfx-demo/src/main/java/com/techsenger/shellfx/demo/dialogs/DialogsDialogPresenter.java

@@ -131,15 +131,6 @@ protected void postInitialize() {
             closeSafely();
         });
         setRightButtons(DialogsDialogButtons.CLOSE);
-//        setMinWidth(400);
-//        setMinHeight(200);
-    }
-
-    @Override
-    protected void applyAppearance() {
-        super.applyAppearance();
-//        setWidth(600);
-//        setHeight(300);
     }
 
     protected void onDialogClick(DialogType type) {

shellfx-demo/src/main/java/com/techsenger/shellfx/demo/page/PageTabParams.java

@@ -16,7 +16,6 @@
 
 package com.techsenger.shellfx.demo.page;
 
-import com.techsenger.patternfx.core.HistoryPolicy;
 import com.techsenger.patternfx.core.HistoryProvider;
 import com.techsenger.shellfx.core.tab.TabParams;
 import java.util.Objects;
@@ -32,7 +31,6 @@ public class PageTabParams extends TabParams {
     public PageTabParams(HistoryProvider<PageTabHistory> historyProvider, PageMenuType menuType) {
         this.menuType = menuType;
         setHistoryProvider(historyProvider);
-        setHistoryPolicy(HistoryPolicy.ALL);
     }
 
     public PageMenuType getMenuType() {

shellfx-demo/src/main/java/com/techsenger/shellfx/demo/styles/StylesTabFxView.java

@@ -18,7 +18,6 @@
 
 import atlantafx.base.theme.Styles;
 import com.techsenger.patternfx.core.ComponentName;
-import com.techsenger.patternfx.core.HistoryPolicy;
 import com.techsenger.patternfx.mvp.ComponentDescriptor;
 import com.techsenger.shellfx.core.ShellFxView;
 import com.techsenger.shellfx.core.page.DefaultPageDescriptor;
@@ -101,7 +100,6 @@ public void compose() {
                 }
             };
             var params = new PageHostParams(null);
-            params.setHistoryPolicy(HistoryPolicy.NONE);
             var hostPresenter = new PageHostPresenter<>(pageHost, params);
             hostPresenter.initialize();
             hostPresenter.setDividerPosition(0.275);