Use preferred size as minimum size for dialogs and popups

Author: pcastornii

tabshell-core/src/main/java/com/techsenger/tabshell/core/dialog/AbstractDialogFxView.java

@@ -55,6 +55,7 @@
 import javafx.scene.layout.HBox;
 import javafx.scene.layout.Pane;
 import javafx.scene.layout.Priority;
+import javafx.scene.layout.Region;
 import javafx.scene.layout.VBox;
 
 /**
@@ -296,6 +297,7 @@ protected void build() {
         super.getNode().getStyleClass().addAll("wrapper", StyleClasses.CORNERS_BOTTOM);
         VBox.setVgrow(super.getNode(), Priority.ALWAYS);
         this.dialogBox.getStyleClass().addAll("dialog-box", StyleClasses.CORNERS_ALL, StyleClasses.SHADOW);
+        dialogBox.setMinSize(Region.USE_PREF_SIZE, Region.USE_PREF_SIZE);
         this.resizer = new RegionResizer(minWidth, minHeight, maxWidth, maxHeight,
                 (e) -> {
                     var event = new DialogResizeEvent(DialogResizeEvent.DIALOG_RESIZE_STARTED, e);

tabshell-core/src/main/java/com/techsenger/tabshell/core/dialog/AbstractDialogPresenter.java

@@ -111,6 +111,7 @@ public boolean isActive() {
         return active;
     }
 
+    @Override
     public void setActive(boolean active) {
         this.active = active;
         getView().setActive(active);
@@ -121,6 +122,7 @@ public double getMinWidth() {
         return minWidth;
     }
 
+    @Override
     public void setMinWidth(double minWidth) {
         this.minWidth = minWidth;
         getView().setMinWidth(minWidth);
@@ -131,6 +133,7 @@ public double getMinHeight() {
         return minHeight;
     }
 
+    @Override
     public void setMinHeight(double minHeight) {
         this.minHeight = minHeight;
         getView().setMinHeight(minHeight);
@@ -141,6 +144,7 @@ public double getMaxWidth() {
         return maxWidth;
     }
 
+    @Override
     public void setMaxWidth(double maxWidth) {
         this.maxWidth = maxWidth;
         getView().setMaxWidth(maxWidth);
@@ -151,6 +155,7 @@ public double getMaxHeight() {
         return maxHeight;
     }
 
+    @Override
     public void setMaxHeight(double maxHeight) {
         this.maxHeight = maxHeight;
         getView().setMaxHeight(maxHeight);
@@ -161,6 +166,7 @@ public boolean isOutOfBoundsAllowed() {
         return outOfBoundsAllowed;
     }
 
+    @Override
     public void setOutOfBoundsAllowed(boolean outOfBoundsAllowed) {
         this.outOfBoundsAllowed = outOfBoundsAllowed;
         getView().setOutOfBoundsAllowed(outOfBoundsAllowed);
@@ -171,6 +177,7 @@ public boolean isResizable() {
         return resizable;
     }
 
+    @Override
     public void setResizable(boolean resizable) {
         this.resizable = resizable;
         getView().setResizable(resizable);

tabshell-core/src/main/java/com/techsenger/tabshell/core/dialog/WriteOnlyDialog.java

@@ -63,6 +63,24 @@ public interface WriteOnlyDialog {
      */
     void setMaxHeight(double value);
 
+    /**
+     * Sets the pref width of the dialog. This is optional — by default, {@code dialogBox} and {@code contentBox}
+     * have {@code minSize} set to {@link Region#USE_PREF_SIZE}, so the dialog will size itself based on its content
+     * automatically.
+     *
+     * @param value the pref width in pixels
+     */
+    void setPrefWidth(double value);
+
+    /**
+     * Sets the pref height of the dialog. This is optional — by default, {@code dialogBox} and {@code contentBox}
+     * have {@code minSize} set to {@link Region#USE_PREF_SIZE}, so the dialog will size itself based on its content
+     * automatically.
+     *
+     * @param value the pref height in pixels
+     */
+    void setPrefHeight(double value);
+
     /**
      * Enables or disables the ability to move the dialog outside the bounds of its parent container.
      * <p>

tabshell-core/src/main/java/com/techsenger/tabshell/core/popup/AbstractPopupFxView.java

@@ -23,6 +23,7 @@
 import javafx.scene.Cursor;
 import javafx.scene.layout.Pane;
 import javafx.scene.layout.Priority;
+import javafx.scene.layout.Region;
 import javafx.scene.layout.StackPane;
 import javafx.scene.layout.VBox;
 
@@ -104,6 +105,7 @@ protected void build() {
         waitingPane.setMouseTransparent(false);
         waitingPane.setCursor(Cursor.WAIT);
 
+        contentBox.setMinSize(Region.USE_PREF_SIZE, Region.USE_PREF_SIZE);
         VBox.setVgrow(contentBox, Priority.ALWAYS);
         VBox.setVgrow(stackPane, Priority.ALWAYS);
     }