Refactor presenters and views for state management

Author: pcastornii

CLAUDE.md

@@ -129,6 +129,14 @@ selectionsByType`, `getSelectionsByType()`/`setSelectionsByType(...)`), not `<ke
 `typeSelections`). The `by`-form reads directly as "which value, keyed by which type of key" at the
 declaration site, without having to look at the generic type arguments to tell which side is the key.
 
+`View` methods follow a naming convention that distinguishes two kinds of methods:
+
+1. State methods — methods that mirror state owned by the `Presenter`. The `Presenter` has the corresponding
+state and a `getX`/`isX` and/or `setX` accessor for it. The corresponding `View` method always starts with
+`update`, e.g. `updateTitle`, `updateModal`, `updateDensity`.
+2. Command methods — all other methods that perform an action rather than mirror `Presenter` state. They use an
+appropriate action verb, such as `showX`, `hideX`, `scrollToFile`, `selectFile`, `clearX`, or `refreshMenu`.
+
 ## Javadoc
 
 Document the contract — what the member does and why a caller would use it — never how it's implemented.

README.md

@@ -617,6 +617,14 @@ Examples of `Composer` methods using `open*` and `close*`:
 | Page      | `openPage(params)`   | `closePage(page)`     | `addPage(page)`     | `removePage(page)`     |
 | Area      | `openArea(params)`   | `closeArea(area)`     | `addArea(area)`     | `removeArea(area)`     |
 
+`View` methods also follow a naming convention that distinguishes two kinds of methods:
+
+1. State methods — methods that mirror state owned by the `Presenter`. The `Presenter` has the corresponding state and
+a `getX`/`isX` and/or `setX` accessor for it. The corresponding `View` method always starts with `update`, e.g.
+`updateTitle`, `updateModal`, `updateDensity`.
+2. Command methods — all other methods that perform an action rather than mirror `Presenter` state. They use an
+appropriate action verb, such as `showX`, `hideX`, `scrollToFile`, `selectFile`, `clearX`, or `refreshMenu`.
+
 ## Quick Start <a name="quick-start"></a>
 
 To get started with ShellFX, it is recommended to follow these steps:

shellfx-core/src/main/java/com/techsenger/shellfx/core/dialog/AbstractDialogFxView.java

@@ -61,27 +61,27 @@ public abstract class AbstractDialogFxView<P extends AbstractDialogPresenter<?>>
             () -> getDescriptor().getLogPrefix());
 
     @Override
-    public void setLeftButtons(ResultButtonName... names) {
+    public void updateLeftButtons(ResultButtonName... names) {
         removeButtons(leftBottomBox);
         addButtons(leftBottomBox, names);
     }
 
     @Override
-    public void setRightButtons(ResultButtonName... names) {
+    public void updateRightButtons(ResultButtonName... names) {
         removeButtons(rightBottomBox);
         addButtons(rightBottomBox, names);
     }
 
     @Override
-    public void setButtonDisabled(ResultButtonName name, boolean value) {
+    public void updateButtonDisabled(ResultButtonName name, boolean value) {
         var button = this.buttonsByName.get(name);
         if (button != null) {
             button.setDisable(value);
         }
     }
 
     @Override
-    public void setButtonDefault(ResultButtonName name, boolean value) {
+    public void updateButtonDefault(ResultButtonName name, boolean value) {
         var button = this.buttonsByName.get(name);
         if (button != null) {
             button.setDefaultButton(value);

shellfx-core/src/main/java/com/techsenger/shellfx/core/dialog/AbstractDialogPresenter.java

@@ -90,7 +90,7 @@ public void setLeftButtons(ResultButtonName... names) {
                 foundNames.add(name);
             }
         }
-        getView().setLeftButtons(foundNames.toArray(ResultButtonName[]::new));
+        getView().updateLeftButtons(foundNames.toArray(ResultButtonName[]::new));
     }
 
     @Override
@@ -104,24 +104,24 @@ public void setRightButtons(ResultButtonName... names) {
                 foundNames.add(name);
             }
         }
-        getView().setRightButtons(foundNames.toArray(ResultButtonName[]::new));
+        getView().updateRightButtons(foundNames.toArray(ResultButtonName[]::new));
     }
 
     @Override
     public void setButtonDisabled(ResultButtonName name, boolean value) {
         var button = this.buttonsByName.get(name);
-        if (button != null) {
+        if (button != null && button.isDisabled() != value) {
             button.setDisabled(value);
-            getView().setButtonDisabled(name, value);
+            getView().updateButtonDisabled(name, value);
         }
     }
 
     @Override
     public void setButtonDefault(ResultButtonName name, boolean value) {
         var button = this.buttonsByName.get(name);
-        if (button != null) {
+        if (button != null && button.isDefault() != value) {
             button.setDefault(value);
-            getView().setButtonDefault(name, value);
+            getView().updateButtonDefault(name, value);
         }
     }
 

shellfx-core/src/main/java/com/techsenger/shellfx/core/dialog/DialogPort.java

@@ -27,7 +27,7 @@
  *
  * @author Pavel Castornii
  */
-public interface DialogPort extends DialogShared, WindowPort {
+public interface DialogPort extends WindowPort {
 
     /**
      * Returns the action to be executed when a result button is clicked.
@@ -83,4 +83,37 @@ public interface DialogPort extends DialogShared, WindowPort {
      *         or empty if the button does not exist
      */
     Optional<Boolean> getButtonDefault(ResultButtonName name);
+
+    /**
+     * Specifies the result buttons in the left side of the dialog's button bar or removes all of them.
+     *
+     * @param names the names of the result buttons to add; pass no arguments to remove all buttons.
+     */
+    void setLeftButtons(ResultButtonName... names);
+
+    /**
+     * Specifies the result buttons in the right side of the dialog's button bar or removes all of them.
+     *
+     * @param names the names of the result buttons to add; pass no arguments to remove all buttons.
+     */
+    void setRightButtons(ResultButtonName... names);
+
+    /**
+     * Sets the disabled state of the specified result button.
+     *
+     * @param name the name of the result button
+     * @param value {@code true} to disable the button, {@code false} to enable it
+     */
+    void setButtonDisabled(ResultButtonName name, boolean value);
+
+    /**
+     * Sets whether the specified result button is the default button for the dialog.
+     * <p>
+     * The default button is typically activated when the user presses Enter. Only one button should be marked
+     * as default at a time.
+     *
+     * @param name the name of the result button
+     * @param value {@code true} to make this button the default, {@code false} otherwise
+     */
+    void setButtonDefault(ResultButtonName name, boolean value);
 }

shellfx-core/src/main/java/com/techsenger/shellfx/core/dialog/DialogShared.java

@@ -17,11 +17,19 @@
 package com.techsenger.shellfx.core.dialog;
 
 import com.techsenger.shellfx.core.window.WindowView;
+import com.techsenger.shellfx.material.button.ResultButtonName;
 
 /**
  *
  * @author Pavel Castornii
  */
-public interface DialogView extends WindowView, DialogShared {
+public interface DialogView extends WindowView {
 
+    void updateLeftButtons(ResultButtonName... names);
+
+    void updateRightButtons(ResultButtonName... names);
+
+    void updateButtonDisabled(ResultButtonName name, boolean value);
+
+    void updateButtonDefault(ResultButtonName name, boolean value);
 }

shellfx-core/src/main/java/com/techsenger/shellfx/core/dialog/DialogView.java

@@ -75,17 +75,17 @@ public Pane getNode() {
     }
 
     @Override
-    public void setPrefWidth(double value) {
+    public void updatePrefWidth(double value) {
         stackPane.setPrefWidth(value);
     }
 
     @Override
-    public void setPrefHeight(double value) {
+    public void updatePrefHeight(double value) {
         stackPane.setPrefHeight(value);
     }
 
     @Override
-    public void setWaiting(boolean waiting) {
+    public void updateWaiting(boolean waiting) {
         if (waiting) {
             stackPane.getChildren().add(waitingPane);
         } else {

shellfx-core/src/main/java/com/techsenger/shellfx/core/popup/AbstractPopupFxView.java

@@ -67,14 +67,20 @@ public double getPrefHeight() {
 
     @Override
     public void setPrefWidth(double prefWidth) {
+        if (this.prefWidth == prefWidth) {
+            return;
+        }
         this.prefWidth = prefWidth;
-        getView().setPrefWidth(prefWidth);
+        getView().updatePrefWidth(prefWidth);
     }
 
     @Override
     public void setPrefHeight(double prefHeight) {
+        if (this.prefHeight == prefHeight) {
+            return;
+        }
         this.prefHeight = prefHeight;
-        getView().setPrefHeight(prefHeight);
+        getView().updatePrefHeight(prefHeight);
     }
 
     @Override
@@ -88,7 +94,7 @@ public void setWaiting(boolean waiting) {
             return;
         }
         this.waiting = waiting;
-        getView().setWaiting(waiting);
+        getView().updateWaiting(waiting);
     }
 
     @Override

shellfx-core/src/main/java/com/techsenger/shellfx/core/popup/AbstractPopupPresenter.java

@@ -24,7 +24,7 @@
  *
  * @author Pavel Castornii
  */
-public interface PopupPort extends AreaPort, PopupShared, CloseAwarePort, Waitable {
+public interface PopupPort extends AreaPort, CloseAwarePort, Waitable {
 
     /**
      * Returns {@code true} if the popup blocks interaction with underlying content (modal) and {@code false} otherwise.
@@ -36,4 +36,8 @@ public interface PopupPort extends AreaPort, PopupShared, CloseAwarePort, Waitab
     double getPrefWidth();
 
     double getPrefHeight();
+
+    void setPrefWidth(double value);
+
+    void setPrefHeight(double value);
 }