Skip to content

"New Message" dialog in app cannot be closed properly #22

Description

@ElninoZhong

Hi team, I ran into a UI issue in the app where the New Message window is difficult or impossible to close properly.

From the client code, NewMessageDialog looks like a custom full-screen overlay instead of using the shared dialog system used elsewhere in the app:

  • apps/client/src/components/dialog/NewMessageDialog.tsx

Current implementation appears to rely on:

  • a custom fixed inset-0 overlay
  • close only wired to the top-right X
  • no shared Dialog open / onOpenChange pattern
  • likely no backdrop-click close
  • likely no Escape close
  • no standard focus / accessibility handling

Suggested fix

Refactor NewMessageDialog to use the same shared dialog pattern already used by components like:

  • CreateChannelDialog
  • CreateWorkspaceDialog
  • CreateSectionDialog

Suggested test cases

  • close via X
  • close via backdrop click
  • close via Esc
  • reset internal search state after close

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions