Hi there! I had a chance to analyse a code of this repo and I have a few suggections for you:
1.Consider adding comments and documentation to your code to explain the purpose of the functions, expected input and output, and any relevant details about how the HTTP requests are being handled. This will make it easier for others (and your future self) to understand and use the package.
2. The code unmarshals the HTTP response body twice in some cases (once to check for errors and then to parse the response into the ret interface). You can optimize this by unmarshaling once and reusing the result if there are no errors.
3. Be cautious when sending and handling sensitive data, such as authorization tokens. Ensure that sensitive data is handled securely and doesn't leak in error messages or logs.
Let me know if there is something I'm missing or if you have any questions
Thanks for your time
Hi there! I had a chance to analyse a code of this repo and I have a few suggections for you:
1.Consider adding comments and documentation to your code to explain the purpose of the functions, expected input and output, and any relevant details about how the HTTP requests are being handled. This will make it easier for others (and your future self) to understand and use the package.
2. The code unmarshals the HTTP response body twice in some cases (once to check for errors and then to parse the response into the ret interface). You can optimize this by unmarshaling once and reusing the result if there are no errors.
3. Be cautious when sending and handling sensitive data, such as authorization tokens. Ensure that sensitive data is handled securely and doesn't leak in error messages or logs.
Let me know if there is something I'm missing or if you have any questions
Thanks for your time