Skip to content

Commit f7b51e9

Browse files
fix: address remaining errcheck findings in s3cache and msi packager
- s3cache.go: defer func() { _ = os.Remove(tmp.Name()) }() in Restore/Store - msi.go: defer func() { _ = os.RemoveAll(stagingDir) }() Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 5aa4965 commit f7b51e9

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

internal/cache/s3cache.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ func (c *S3Cache) Restore(ctx context.Context, key, destDir string) error {
8383
if err != nil {
8484
return err
8585
}
86-
defer os.Remove(tmp.Name())
86+
defer func() { _ = os.Remove(tmp.Name()) }()
8787
defer tmp.Close()
8888

8989
if _, err := io.Copy(tmp, out.Body); err != nil {
@@ -104,7 +104,7 @@ func (c *S3Cache) Store(ctx context.Context, key, srcDir string) error {
104104
if err != nil {
105105
return err
106106
}
107-
defer os.Remove(tmp.Name())
107+
defer func() { _ = os.Remove(tmp.Name()) }()
108108
defer tmp.Close()
109109

110110
if err := archiveDir(srcDir, tmp.Name()); err != nil {

internal/packager/msi/msi.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ func (m *MSIPackager) Pack(ctx context.Context, proj *project.Definition, instal
4242
if err != nil {
4343
return nil, err
4444
}
45-
defer os.RemoveAll(stagingDir)
45+
defer func() { _ = os.RemoveAll(stagingDir) }()
4646

4747
if err := os.MkdirAll(outputDir, 0o755); err != nil {
4848
return nil, err

0 commit comments

Comments
 (0)