Messages do not sync between computers

[nbolton]

By @davehorner on #19:

any idea why I can't seem to get messages to the other windows that are not sync? I can see sync go across all the windows. with the extension reload, it reloads the current window. I should be able to broadcast a message to the other vscode windows as they are connected to the websocket. almost leads me to extending sync in ways it should not.

I figured we could discuss here so we can focus on sync/websocket issues in it's own context. I hope separate threads make it easier to follow and not harder! :)

windows that are not sync

Are they connecting to the websocket but not getting a message?

Please share your debug logs for the extension (you can filter by the value of log tag).

Dev tools: Ctrl+Shift+I (Linux)
Filter: [multi-build]
Log level: +Verbose

[nbolton]

Here's what good looks like, in case that's useful...

Initial connection:

[Extension Host] [multi-build] Initializing (at console.<anonymous> (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:172:27485))
console.ts:137 [Extension Host] [multi-build] Registering command: multiBuild.sync (at console.<anonymous> (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:172:27485))
console.ts:137 [Extension Host] [multi-build] Registering command: multiBuild.reconnect (at console.<anonymous> (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:172:27485))
console.ts:137 [Extension Host] [multi-build] Server config: {baseUrl: 'wss://multi-build-server.symless.workers.dev', roomId: '337c1988-d514-42a2-b9d9-a5b6bed18839'} (at console.<anonymous> (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:172:27485))
console.ts:137 [Extension Host] [multi-build] Using existing room ID: 337c1988-d514-42a2-b9d9-a5b6bed18839 (at console.<anonymous> (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:172:27485))
console.ts:137 [Extension Host] [multi-build] Watching for config changes (at console.<anonymous> (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:172:27485))
console.ts:137 [Extension Host] [multi-build] Connecting WebSocket, room: 337c1988-d514-42a2-b9d9-a5b6bed18839 (at console.<anonymous> (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:172:27485))
console.ts:137 [Extension Host] [multi-build] Getting auth token (at console.<anonymous> (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:172:27485))
console.ts:137 [Extension Host] [multi-build] Auth session found: ec63ebd97094d0c (at console.<anonymous> (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:172:27485))
console.ts:137 [Extension Host] [multi-build] Initialized (at console.<anonymous> (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:172:27485))
console.ts:137 [Extension Host] [multi-build] WebSocket connection opened (at console.<anonymous> (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:172:27485))
console.ts:137 [Extension Host] [multi-build] Hello back message received (at console.<anonymous> (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:172:27485))

Sending a sync:

[Extension Host] [multi-build] Saving changes to config: {repo: 'synergy', remote: 'origin', branch: 'master'} (at console.<anonymous> (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:172:27485))
console.ts:137 [Extension Host] [multi-build] Pushing changes to server (at console.<anonymous> (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:172:27485))
console.ts:137 [Extension Host] [multi-build] Sync message received: {repo: 'synergy', remote: 'origin', branch: 'master'} (at console.<anonymous> (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:172:27485))
console.ts:137 [Extension Host] [multi-build] Syncing repo: synergy, remote: origin, branch: master (at console.<anonymous> (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:172:27485))
console.ts:137 [Extension Host] [multi-build] Checking out branch 'master' in repository synergy (at console.<anonymous> (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:172:27485))
console.ts:137 [Extension Host] [multi-build] Checked out branch 'master' in repository synergy (at console.<anonymous> (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:172:27485))
console.ts:137 [Extension Host] [multi-build] CMake configure (at console.<anonymous> (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:172:27485))
console.ts:137 [Extension Host] [multi-build] Waiting for CMake (at console.<anonymous> (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:172:27485))
console.ts:137 [Extension Host] [multi-build] CMake build (at console.<anonymous> (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:172:27485))

Recieve a sync:

[Extension Host] [multi-build] WebSocket message received: {"type":"sync","data":{"repo":"synergy","remote":"origin","branch":"master"}}
console.ts:137 [Extension Host] [multi-build] Sync message received: {repo: 'synergy', remote: 'origin', branch: 'master'}
console.ts:137 [Extension Host] [multi-build] Syncing repo: synergy, remote: origin, branch: master
console.ts:137 [Extension Host] [multi-build] Checking out branch 'master' in repository synergy
console.ts:137 [Extension Host] [multi-build] Sending message: keep-alive {}
console.ts:137 [Extension Host] [multi-build] WebSocket message received: {"type":"ack"}
console.ts:137 [Extension Host] [multi-build] Ack message received
console.ts:137 [Extension Host] [multi-build] Branch 'master' already exists
console.ts:137 [Extension Host] [multi-build] Checked out branch 'master' in repository synergy
console.ts:137 [Extension Host] [multi-build] CMake configure

[davehorner]

The title is a little confusing; or could be confusing as we are discussing a sync event and I am also re-using the words to say they aren't handling the messages that are not past the sync message or hello/ack/keep-alive all come through.

I need to re-merge where we are now to get good notes.

        await vscode.commands.executeCommand('workbench.extensions.installExtension', vscode.Uri.file(foundVsix));
        // Broadcast a refresh command to all connected instances after successful upgrade
        vscode.commands.executeCommand('workbench.action.reloadWindow');
        if (roomSocket) {
          sendMessage({ type: "refresh-all-windows" });
          vscode.window.showInformationMessage("Multi-Build: Refresh command sent to all connected instances.");
        } else {
          vscode.window.showInformationMessage("Multi-Build: No WebSocket connection (roomSocket is 0), not refreshing other code instances.");
        }

it installs the extension and it refreshes itself fine.

sendMessage({ type: "refresh-all-windows" });

I would think that the other windows would receive this message and:

      } else if (message.type === "refresh-all-windows") {
        console.log(`${logTag} Received refresh-all-windows command.`);

        // Refresh the current window
        await vscode.commands.executeCommand("workbench.action.reloadWindow");

would cause them to also reload. I don't see the broadcast come through. But I do see sync messages come thru to the other windows...that's whats got me confused.

[nbolton]

The title is a little confusing

I can change it to be more accurate. Perhaps I don't undersrand the problem.

sendMessage({ type: "refresh-all-windows" });

The type is strict; it's not simply a relay, it also processes the message:
https://github.com/symless/multi-build-server/blob/46797a008400eec32143dd6a543234276d3b5e5c/src/index.ts#L138

We can certainly add message types, but I think we could add a generic broadcast-command message with a custom data payload which runs whatever command you want, which is perhaps how I could solve:

• Only run CMake if it can be run #14

[davehorner]

I don't know how to get debugs from the parent (first vscode window); I can see the logs in the first vscode window for the debugged instance of vscode that opens when you hit f5. its the reason I threw show messages all over. If I don't have it under debug, I don't see the logs.

[nbolton]

Here's how I do it:

1. Run npm run watch
2. Press F5 to launch the extension in a new instance of VS Code
3. In the newly launched instance of VS Code, open the dev tools (Ctrl+Shift+I on Linux)
4. Enable the 'Verbose' log level
5. Filter by "[multi-build]"

See also: https://github.com/symless/multi-build/wiki/Contributing

[nbolton]

@davehorner BTW, I updated the server readme: https://github.com/symless/multi-build-server