Long-press on an inactive server fires a server switch instead of opening the context menu

[classicjazz]

What happened?

Expected

Long-press opens the context menu on every row. The on-screen hint says so: "Long-press a server to switch, set as default, or remove it."

Actual

On an inactive row the switch fires immediately, so on build 20 you get the "Couldn't switch server" alert from Issue 1 instead of a menu. There is consequently no way to remove or pin an inactive server from this screen.

Note this is a separate defect from Issue 74 and would misbehave even with a valid token — you would simply be switched to that server rather than shown the menu you asked for.

Steps to reproduce

1. Settings → Servers, with two or more servers configured.
2. Long-press the active server → the context menu opens (Set as Default / Edit URLs / Remove). Correct.
3. Long-press any inactive server → no context menu; the app attempts a server switch instead.

Sodalite build

1.0.0 (20)

tvOS version

26

Apple TV model

Apple TV 4k gen 3

Jellyfin server version

10.11.11

Media (if a playback bug)

No response

Anything else

This is Claude's analysis of the issue after reviewing the current code base

Diagnosis

StableTapModifier (Components/StableTap.swift) implements row activation on tvOS as:

#if os(tvOS)
.onLongPressGesture(minimumDuration: 0.01) { fireIfStable() }
#else
.onTapGesture { action() }
#endif

The action fires roughly 10 ms into any press, so a deliberate long press triggers the row's primary action before, and in competition with, the .contextMenu attached in ServerManagementView.

The asymmetry between active and inactive rows is explained by the guard in ServerManagementView.switchTo(_:):

guard server.id != activeID else { return }

On the active row the primary action is a no-op, so the context menu comes through unobstructed. On every other row it is not.

Suggested fix

On tvOS, gate the primary action on a press that is not long — e.g. a bounded press gesture, or suppressing stableTap's action while a context menu is presenting. Any row in the app that pairs stableTap with .contextMenu is affected by the same interaction, so the fix probably belongs in StableTapModifier rather than in ServerManagementView.

[superuser404notfound]

Fixed on main in 1dca904 (merge b561e52). Thanks for separating this from #74, that was the right call: it is its own defect and it would have kept misbehaving once the switch started working.

The diagnosis pointed at the right file. stableTap decides the click about 10 ms into any press, so a row that also carries a .contextMenu acts on the way into its own menu, and the active row only looked correct because its primary action is a no-op.

One detail worth adding, since it decided the shape of the fix: this affects exactly one row in the app rather than a class of them. The other four .contextMenu sites (the profile card in the picker, the spoiler rule, the season tab, the episode card) hang on real Buttons, which decide on release already and never had the overlap. So the fix is a longPressOpensMenu option on stableTap, set on the server row alone, rather than a change to how the other ~29 rows activate.

With it the press decides on release and counts as a click only below 0.4 s, which sits under the roughly half second at which tvOS opens the menu, so the two readings of one press cannot both win. The focus-stability window that stableTap exists for is now judged when the press starts rather than when it ends: measured at release, the hold itself would count as steadiness and let through exactly the Siri Remote drift the window was built to catch.

Both readings of the row survive: a short click on an inactive row still switches, and the hold now reaches the menu, where "Switch", "Set as Default", "Edit URLs" and "Remove" are all available on an inactive server.

This will be in the next TestFlight build. Worth a look in particular at whether a deliberate click on an inactive row still feels immediate, since it now lands on release rather than on the press. Leaving this open until then.

[classicjazz]

Verified on 1.0.0 (25)

• Long-Press Behavior: Works as expected. Holding an inactive server row brings up the context menu ("Switch", "Set as Default", "Edit URLs", "Remove") without triggering an immediate, unintended switch error message.
• Short-Click Responsiveness: Standard clicks to switch servers still feel natural and immediate on release.
• Menu Dismissal & Focus: Dismissing the menu or selecting an action executes cleanly and leaves focus predictably on the server row.

Fix verified! Safe to close.