Skip to content

Commit 42acfcb

Browse files
author
Vincent
authored
Merge pull request #428 from superuser404notfound/diag/ae409-cadence-line
diag(video): the #409 verdict line names the cadence it measured
2 parents 69daa3d + 14a079c commit 42acfcb

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

Sources/AetherEngine/Video/H264CompositionOffsetRepair.swift

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -729,8 +729,15 @@ final class H264CompositionOffsetRepairSession {
729729
)
730730
switch verdict {
731731
case .repair(let plan):
732+
// The cadence and its phase belong in the line: on a fractional ladder they are the
733+
// reading the verdict rests on, and a repair that reports only a rounded step cannot be
734+
// told apart from one that measured the ladder wrong.
735+
let cadenceDescription = plan.cadence.map {
736+
" cadence=\($0.numerator)/\($0.denominator) phase=\(plan.ladderPhase)"
737+
+ " ladderAhead=\(plan.ladderOrdinalOffset)"
738+
} ?? ""
732739
verdictDescription = "repair step=\(plan.step) lead=\(plan.decodeLead) "
733-
+ "shift=\(plan.shift) pocStep=\(plan.pocStep)"
740+
+ "shift=\(plan.shift) pocStep=\(plan.pocStep)" + cadenceDescription
734741
phase = .repairing
735742
var rewriter = H264CompositionOffsetRepair.Rewriter(plan: plan)
736743
for entry in held where entry.packet.pointee.stream_index == streamIndex {

0 commit comments

Comments
 (0)