Skip to content

Commit 6940331

Browse files
authored
chore: relax devEngines.packageManager requirements (#6459)
<!-- Before opening this PR, confirm the linked issue is open and carries the `open-for-contribution` label. PRs from external contributors that don't follow the workflow in CONTRIBUTING.md are closed automatically. @supabase members working from Linear tickets are exempt. --> ## Summary In #6424, I added a strict `onFail: 'error'` property so any time someone uses `npm`, `yarn,` or an incorrect `pnpm` version, those CLIs error out. This was a bit aggressive — we use the `npm` CLI for a variety of things related to our release process. Rather than backport all of those `npm` usages to `pnpm`, I opted to update `onFail` to be `warn`. That should unblock one error in our release process, hopefully that's all of them? I'm not sure what to make of [this error](https://github.com/supabase/cli/actions/runs/33785688700/job/100750659098) 🤔
1 parent 81a1f81 commit 6940331

2 files changed

Lines changed: 1 addition & 4 deletions

File tree

.github/workflows/publish-preview-cli-packages.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,9 +131,6 @@ jobs:
131131
PREVIEW_URL: ${{ steps.preview-metadata.outputs.preview_url }}
132132
run: |
133133
set -euo pipefail
134-
# Run outside the checkout: npm enforces the root package.json's
135-
# devEngines.packageManager (pnpm) against itself and would refuse.
136-
cd "${RUNNER_TEMP}"
137134
npx --yes "${PREVIEW_URL}" --version
138135
139136
comment:

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
"packageManager": {
4646
"name": "pnpm",
4747
"version": "12.3.0",
48-
"onFail": "error"
48+
"onFail": "warn"
4949
}
5050
}
5151
}

0 commit comments

Comments
 (0)