Bugs in noise_source_location?

[ge98fiy]

1. l. 76, 107 & 141: the diameter should be divided by 20 and not 200 acc. to p.73 in SAE ARP876.

2. l.94 & 104: The las part of the equation for XJ should read: (Velocity_secondary/Velocity_aircraft) instead of (Velocity_secondary/(Velocity_secondary-Velocity_aircraft)):

3. Whereever the parameter B is calculated: I think the brackets are wrong here, because the eqaution reads "XXX/sin(theta) + cot(theta)" instead of "XXX + cot(theta)" [--> cot(theta) = cos(theta) / sin(theta)]. See screenshot from SAE ARP876 below:

[planes]

Hi! We appreciate you finding all these issues.

The developer who put all this module together is no longer actively developing SUAVE. So if you're able, we would welcome a pull request with these fixes. Let me know if you have any questions. I'm happy to help.

[ge98fiy]

Hey Emilio,

Thanks for replying. What a pitty that the developer is no longer working on SUAVE...

Actually, I only took the python code as a baseline to transform it to a Matlab code, so I'm not really working on your code. However, I thought it'd be kind to tell you about the issues/bugs I've found when comparing the code to the original source, so I opened the issues. Most of the things are pretty straight forward to change and don't need to be discussed I think. Nevertheless, I'd welcome your opinion on issues #592 and #589, as I'm unsure about these.

Looking forward to your comments,
Anna