Move to DateTimeOffset from DateTime

[kerams]

Is your feature request related to a problem? Please describe.

Explained in #2218 (comment).

Describe the solution you'd like

Every date + time value should be typed as DateTimeOffset.

Describe alternatives you've considered

Continue converting data from stripe-net to DateTimeOffset myself manually.

Additional context

No response

[jar-stripe]

Hi @kerams , thanks for submitting the feature request! I definitely see where you're coming from, but I think also that #2218 (comment) raises a valid point about being able to accept timezone aware DateTimes and do the right thing with them w.r.t. the Stripe API.

If you don't mind sharing, how complicated is the manual conversion you have to do? If the Stripe.NET SDK had a static extension or other helper function for DateTime that would do that conversion for you, e.g.:

using Stripe.Extensions; // defines public static DateTimeOffset AsDateTimeOffset(DateTime dt);

var offset = object.Created.AsDateTimeOffset();
...

would that be helpful here?

In either case we will add this to our backlog to consider what the right solution is. Thanks again for your input here!

[kerams]

The concern is the fact that I have to do it at all, even though it is trivial.

accept timezone aware DateTimes and do the right thing with them w.r.t. the Stripe API

Neither of these 2 types is time zone-aware, but DTO is inherently more appropriate (what happens when you pass in a local DT with a value of 2am on the date when clocks fall back?). An instance of DTO always indentifies a specific point in time, whereas DT can be ambiguous with non-UTC Kind, either because of the aforementioned daylight saving changes or because of incorrect system time zone setting.

The current output behavior is correct since Stripe always returns UTC DT, but I don't see any good reason why you'd want to keep using DT other than to maintain the status quo. DTO is simply more robust, both as input and output.

[jar-stripe]

Thanks for the quick response and the detailed info! I'll make sure this is all captured in the ticket.