Skip to content

Verse of the day should be changed based on date and not day number #10

Description

@stoiandan

Currently in src/verseOfTheDay.js there is mechanism in place to check each time the verse of the day is request, if it has expired or not (i.e. if it's still the same day), this has been implemented by comparing day numbers (example Sunday = 1, Monday = 2), instead of whole dates (i.e. 23.05.2021).
This is a bug because if a user only uses the browser on, say, Sundays, the mechanism will conclude it's the same date, which is wrong, and not fetch a new verse of the day.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions