fix: open equipped bags with occupied cursor

Author: stinowdev

CHANGELOG.md

@@ -4,16 +4,30 @@ All notable changes to this project will be documented in this file.
 
 Feature (F) and decision (D) numbers refer to [FEATURES.md](FEATURES.md).
 
+## [v0.5.2](https://github.com/stinowdev/vs-burdened/releases/tag/v0.5.2)
+
+The 0.5.2 patch fixes opening equipped bags while moving items.
+
+<img
+  alt="Fix cursor carrying item"
+  src="https://github.com/user-attachments/assets/223e212b-2b52-4cae-a218-b5f335ad94fb"
+/>
+
+### Fixed
+
+- Equipped bags can now be opened while the cursor carries an item. Opening the
+  bag leaves that item untouched.
+
 ## [v0.5.1](https://github.com/stinowdev/vs-burdened/releases/tag/v0.5.1)
 
+The 0.5.1 patch fixes stale item rendering in equipped-bag windows.
+
 <img
   width="600"
   alt="Fix #7"
   src="https://github.com/user-attachments/assets/38b17f0f-39d7-4740-96f4-81cbcb4e8224"
 />
 
-The 0.5.1 patch fixes stale item rendering in equipped-bag windows.
-
 ### Fixed
 
 - Equipped-bag windows no longer render an occupied slot as empty, or keep an

FEATURES.md

@@ -45,6 +45,8 @@ follows the table below for everything after that.
 The following rules apply to every transition:
 
 - Bag contents remain attached to the item stack.
+- Opening an equipped bag does not require an empty cursor and does not move the
+  cursor stack.
 - A rejected pickup or placement leaves the source unchanged.
 - Floor pickup never falls back to general inventory routing or the offhand.
 - Several equipped bag windows may remain open at once.

README.md

@@ -61,7 +61,7 @@ bags remain on the body.
 |---|---|---|
 | Placed bag | Right-click | Open the bag |
 | Placed bag | Shift + right-click | Equip it into a compatible empty bag slot |
-| Equipped bag slot | Right-click | Open or close that bag |
+| Equipped bag slot | Right-click | Open or close that bag (also with cursor stack) |
 | Equipped bag slot | Shift + click | Place it on the targeted block |
 | Selected equipped bag | Right-click | Open or close the bag when the targeted block does not use the input |
 | Selected equipped bag | Shift + right-click | Place it on the targeted block |

resources/modinfo.json

@@ -4,7 +4,7 @@
   "name": "Burdened",
   "authors": [ "stinow" ],
   "description": "A weightier carrying experience: fewer slots, immersive bag carrying, placeable and openable bags.",
-  "version": "0.5.1",
+  "version": "0.5.2",
   "side": "universal",
   "requiredOnClient": true,
   "requiredOnServer": true,

src/Patches/BagInteractionPatches.cs

@@ -303,6 +303,13 @@ public static bool BagSlotClickPrefix(
         if (slot.Empty
             || !BagSupport.SupportsEquippedBagWindow(slot.Itemstack)
             || SlotLocks.IsLocked(slot)) return true;
+
+        if (!shiftPressed && mouseButton == EnumMouseButton.Right)
+        {
+            GuiDialogEquippedBag.Toggle(api, slotId);
+            return false;
+        }
+
         if (!api.World.Player.InventoryManager.MouseItemSlot.Empty) return true;
 
         if (shiftPressed && (mouseButton == EnumMouseButton.Left || mouseButton == EnumMouseButton.Right))
@@ -317,12 +324,6 @@ public static bool BagSlotClickPrefix(
             return false;
         }
 
-        if (mouseButton == EnumMouseButton.Right)
-        {
-            GuiDialogEquippedBag.Toggle(api, slotId);
-            return false;
-        }
-
         return true;
     }