Skip to content

Commit b73da33

Browse files
committed
Update java version in pom files and add slf4j to the sample pom
1 parent e31428c commit b73da33

3 files changed

Lines changed: 20 additions & 4 deletions

File tree

‎doc/corenlp/pom-full.xml‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@
3535
</developer>
3636
</developers>
3737
<properties>
38-
<maven.compiler.source>1.8</maven.compiler.source>
39-
<maven.compiler.target>1.8</maven.compiler.target>
38+
<maven.compiler.release>11</maven.compiler.release>
4039
<encoding>UTF-8</encoding>
4140
</properties>
4241
<dependencies>

‎doc/corenlp/pom-light.xml‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@
3535
</developer>
3636
</developers>
3737
<properties>
38-
<maven.compiler.source>1.8</maven.compiler.source>
39-
<maven.compiler.target>1.8</maven.compiler.target>
38+
<maven.compiler.release>11</maven.compiler.release>
4039
<encoding>UTF-8</encoding>
4140
</properties>
4241
<build>

‎examples/sample-maven-project/pom.xml‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,31 @@
77
<version>1.0-SNAPSHOT</version>
88
<name>stanford-corenlp-test-app</name>
99
<url>http://maven.apache.org</url>
10+
11+
<properties>
12+
<corenlp.version>4.6.0</corenlp.version>
13+
<maven.compiler.release>11</maven.compiler.release>
14+
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
15+
</properties>
16+
17+
1018
<dependencies>
1119
<dependency>
1220
<groupId>junit</groupId>
1321
<artifactId>junit</artifactId>
1422
<version>4.13.1</version>
1523
<scope>test</scope>
1624
</dependency>
25+
<!-- CoreNLP logs some messages through the SLF4J API, and leaves the
26+
choice of logging backend to the application. slf4j-simple prints
27+
them to stderr. It must be a 1.7.x version, to match the
28+
slf4j-api version CoreNLP uses -->
29+
<dependency>
30+
<groupId>org.slf4j</groupId>
31+
<artifactId>slf4j-simple</artifactId>
32+
<version>1.7.36</version>
33+
<scope>runtime</scope>
34+
</dependency>
1735
<dependency>
1836
<groupId>edu.stanford.nlp</groupId>
1937
<artifactId>stanford-corenlp</artifactId>

0 commit comments

Comments
 (0)