Summary
Tracks deferred items from PR #63 audit review and additional internal findings.
To be addressed as a focused followup PR after #63 merges to stage.
PR #63 review threads
Additional findings
Out of scope
- Aliasing concern (defensive copy in
overlayLookup) — discussed in PR #60 thread, going with the documented-contract approach. Revisit only if patterns prove fragile.
Summary
Tracks deferred items from PR #63 audit review and additional internal findings.
To be addressed as a focused followup PR after #63 merges to stage.
PR #63 review threads
mockHeadStateBuilder+ parametric tests over revert classifications (thread)BuildHeadStateSnapshot— idempotency docstring (thread)GetFinalizedClusters— batchedSELECT ... IN (?, ?)to avoid serialising DB I/O (thread)storeRawEvent— remove dead!errors.Is(parseErr, errUnknownEvent)branch (thread)applyClusterEventToOverlay— doc note on operator-set assumption (thread)oracle.commit— reorderVerifyFinalizedBlockRootbeforeGetActiveValidators(thread)Additional findings
processAllClustersstats undercount on SSV-OR-9 early-returngo.modBuildHeadStateSnapshotfailure marks event processed → consider retry-before-advanceOut of scope
overlayLookup) — discussed in PR #60 thread, going with the documented-contract approach. Revisit only if patterns prove fragile.