From 1cbc7c75bd0d3bb32b4d11dcec41014515c7ebb6 Mon Sep 17 00:00:00 2001 From: Kasper Thystrup Karstensen Date: Wed, 5 Aug 2026 12:45:38 +0200 Subject: [PATCH 1/8] Impose patch version restrictions for minor version increments When making relations between versions numerically (by first removing dot between minor and patch, then by removing the build entirely) every minor releases of 10 leads to ambiguity Example: 2.20.0 SHOULD be greater than 2.2.0 - as in: 2.20.0 > 2.2.0 However 2.20.0 < 2.2.0 numerically becomes 2.200 < 2.20 which is FALSE (it is rather 2.200 == 2.20) This is now circumvented by always setting patch to 1 whenever a new minor is incremented. Now e.g. 2.19.+ minor version increments directly to 2.20.1 Thus we can never get a situation where we get both a version 2.2.0 AND a version 2.20.0 --- .github/scripts/bump_version.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/scripts/bump_version.py b/.github/scripts/bump_version.py index e79db12..1a8b257 100644 --- a/.github/scripts/bump_version.py +++ b/.github/scripts/bump_version.py @@ -20,7 +20,7 @@ elif label == "feature": minor += 1 - patch = 0 + patch = 1 build = 0 elif label == "patch": From b2929f60acdc3c61b9129156ebd861a05586ade0 Mon Sep 17 00:00:00 2001 From: Kasper Thystrup Karstensen Date: Wed, 5 Aug 2026 12:52:00 +0200 Subject: [PATCH 2/8] Implement modulo check for minor version increments --- .github/scripts/bump_version.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/scripts/bump_version.py b/.github/scripts/bump_version.py index 1a8b257..e0cd0d3 100644 --- a/.github/scripts/bump_version.py +++ b/.github/scripts/bump_version.py @@ -20,7 +20,11 @@ elif label == "feature": minor += 1 - patch = 1 + patch = 0 + # Determine every tens of minor version increments (10, 20, 30 etc.) + if (10 % minor) == 0: + # Set patch version to 1 directly + patch = 1 build = 0 elif label == "patch": From 201120618ded3521b81c570cc40d8991f1417e4f Mon Sep 17 00:00:00 2001 From: Kasper Thystrup Karstensen Date: Wed, 5 Aug 2026 12:53:42 +0200 Subject: [PATCH 3/8] Fix modulo condition whoops --- .github/scripts/bump_version.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/scripts/bump_version.py b/.github/scripts/bump_version.py index e0cd0d3..8da69e2 100644 --- a/.github/scripts/bump_version.py +++ b/.github/scripts/bump_version.py @@ -22,7 +22,7 @@ minor += 1 patch = 0 # Determine every tens of minor version increments (10, 20, 30 etc.) - if (10 % minor) == 0: + if (minor % 10) == 0: # Set patch version to 1 directly patch = 1 build = 0 From 3eb964d00e7e77a259b055402e9dab75428b4105 Mon Sep 17 00:00:00 2001 From: Kasper Thystrup Karstensen Date: Wed, 5 Aug 2026 12:56:17 +0200 Subject: [PATCH 4/8] Increase sleep duration in validation workflow Increased delay from 30 seconds to 120 seconds for execution. --- .github/workflows/VALIDATION.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/VALIDATION.yml b/.github/workflows/VALIDATION.yml index d616558..ba3bc1d 100644 --- a/.github/workflows/VALIDATION.yml +++ b/.github/workflows/VALIDATION.yml @@ -33,7 +33,7 @@ jobs: - name: Delayed execution if: steps.check.outputs.result == 'wait' - run: sleep 30 + run: sleep 120 - name: Check labels uses: actions/github-script@v7 From 449311bf0e657dd6ffc5bc16155bb4e8c6c08b15 Mon Sep 17 00:00:00 2001 From: Kasper Thystrup Karstensen Date: Wed, 5 Aug 2026 13:21:55 +0200 Subject: [PATCH 5/8] Added skip step --- .github/workflows/VALIDATION.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/VALIDATION.yml b/.github/workflows/VALIDATION.yml index ba3bc1d..5eb4a33 100644 --- a/.github/workflows/VALIDATION.yml +++ b/.github/workflows/VALIDATION.yml @@ -77,6 +77,7 @@ jobs: build: needs: check-label + if: ${{ !contains(github.event.pull_request.labels.*.name, 'build') }} strategy: matrix: From f28f3fb5eb1d914ef6330a3bba26f9c4c4166cb4 Mon Sep 17 00:00:00 2001 From: Kasper Thystrup Karstensen Date: Wed, 5 Aug 2026 13:23:50 +0200 Subject: [PATCH 6/8] Cherry picked steps to skip --- .github/workflows/VALIDATION.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/VALIDATION.yml b/.github/workflows/VALIDATION.yml index 5eb4a33..94f413f 100644 --- a/.github/workflows/VALIDATION.yml +++ b/.github/workflows/VALIDATION.yml @@ -77,7 +77,6 @@ jobs: build: needs: check-label - if: ${{ !contains(github.event.pull_request.labels.*.name, 'build') }} strategy: matrix: @@ -93,12 +92,14 @@ jobs: uses: actions/checkout@v4 - name: Setup Micromamba + if: ${{ !contains(github.event.pull_request.labels.*.name, 'build') }} uses: mamba-org/setup-micromamba@v2 with: environment-name: test-env init-shell: bash - name: Test conda installation + if: ${{ !contains(github.event.pull_request.labels.*.name, 'build') }} shell: bash -l {0} run: | micromamba install conda --yes @@ -108,11 +109,13 @@ jobs: pip install . - name: Verify package imports + if: ${{ !contains(github.event.pull_request.labels.*.name, 'build') }} shell: bash -l {0} run: | mmaseq --version - name: Test pipeline + if: ${{ !contains(github.event.pull_request.labels.*.name, 'build') }} shell: bash -l {0} run: | mmadeploy --deploy_dir ~/test --threads 3 --test --verbosity 2 From 698d96aa8de99c0af279ce5851305547e171c175 Mon Sep 17 00:00:00 2001 From: Kasper Thystrup Karstensen Date: Wed, 5 Aug 2026 13:28:48 +0200 Subject: [PATCH 7/8] Added prelimenary message --- .github/workflows/VALIDATION.yml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.github/workflows/VALIDATION.yml b/.github/workflows/VALIDATION.yml index 94f413f..672a44d 100644 --- a/.github/workflows/VALIDATION.yml +++ b/.github/workflows/VALIDATION.yml @@ -91,6 +91,17 @@ jobs: - name: Checkout repository uses: actions/checkout@v4 + - name: Checking PR status + uses: actions/github-script@v7 + with: + script: | + const labels = context.payload.pull_request.labels.map(l => l.name); + + if (labels.includes('build')) { + console.log("PR is labelled 'build', thus no changes in software is imminent. Skipping remainder!"); + } + + - name: Setup Micromamba if: ${{ !contains(github.event.pull_request.labels.*.name, 'build') }} uses: mamba-org/setup-micromamba@v2 From 324974ed4e73db60e9dd2f684e0de224698ebe8f Mon Sep 17 00:00:00 2001 From: Kasper Thystrup Karstensen Date: Wed, 5 Aug 2026 13:34:31 +0200 Subject: [PATCH 8/8] Cleared log msg --- .github/workflows/VALIDATION.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/VALIDATION.yml b/.github/workflows/VALIDATION.yml index 672a44d..b84afca 100644 --- a/.github/workflows/VALIDATION.yml +++ b/.github/workflows/VALIDATION.yml @@ -98,7 +98,7 @@ jobs: const labels = context.payload.pull_request.labels.map(l => l.name); if (labels.includes('build')) { - console.log("PR is labelled 'build', thus no changes in software is imminent. Skipping remainder!"); + console.log("PR is labelled 'build', thus no changes in software is imminent. Check is done sucessfully!"); }