Support visual vim linewise X and S

Author: SqlRush

docs/first-second-parity-audit.md

@@ -253,7 +253,7 @@ M7 progress now includes:
 - `internal/tui`: Vim prompt editing now supports `/`, `?`, `n`, and `N` in visual and visual-line modes, returning from the search prompt to the active selection on Enter and preserving the original selection on Escape cancellation.
 - `internal/tui`: Vim prompt editing now supports `"{reg}` named register prefixes across normal/operator/visual yank, delete, and paste paths, including uppercase append registers, black-hole no-op handling, and cleanup of unused register selections after non-register commands.
 - `internal/tui`: Vim prompt editing now updates unnamed or selected named registers for normal-mode `x`/`X` character deletions while preserving dot-repeat replay for those delete commands.
-- `internal/tui`: Vim prompt editing now supports visual and visual-line `Y`/`D`/`C` linewise aliases, forcing characterwise selections to operate on whole selected lines while preserving linewise unnamed or named register contents.
+- `internal/tui`: Vim prompt editing now supports visual and visual-line `Y`/`D`/`C`/`X`/`S` linewise aliases, forcing characterwise selections to operate on whole selected lines while preserving linewise unnamed or named register contents.
 - `internal/session`: prompt history now persists image pasted-content metadata such as media type, filename, dimensions, and image-cache source path while still omitting inline base64 image bytes and text-paste hashes for images.
 - `internal/session`: prompt history loading now backfills missing image source paths from existing per-session image-cache files and refreshes the in-memory image path cache when those files exist.
 - `internal/tui`: interaction script key fields now accept DOM-style key event objects with `key`/`code` including `Numpad*`, extended numpad paren/hash/backspace codes, and punctuation key codes, legacy `keyIdentifier`, numeric `keyCode`/`which`/`charCode` including punctuation and numpad operators, `keypress.which` char-code replay, modifier booleans such as `ctrlKey`/`altKey`/`metaKey`/`shiftKey`, and modifier arrays, including wrapper payloads and modifier-only event filtering.

internal/tui/tui_test.go

@@ -4500,6 +4500,17 @@ func TestREPLScreenVimVisualUppercaseLineOperators(t *testing.T) {
 		t.Fatalf("after visual \"aD screen = %#v", screen)
 	}
 
+	screen = NewREPLScreen(40, 8, nil)
+	screen.SetVimEnabled(true)
+	typePromptText(&screen, "one\ntwo\nthree")
+	screen.ApplyKey(ParseKey("\x1b"))
+	for _, seq := range []string{"g", "g", "j", "v", "l", "X"} {
+		screen.ApplyKey(ParseKey(seq))
+	}
+	if screen.VimMode != VimNormal || screen.Prompt.Text != "one\nthree" || screen.Prompt.Cursor != len([]rune("one\n")) || screen.VimRegister != "two\n" || !screen.VimRegisterLinewise {
+		t.Fatalf("after visual X screen = %#v", screen)
+	}
+
 	screen = NewREPLScreen(40, 8, nil)
 	screen.SetVimEnabled(true)
 	typePromptText(&screen, "one\ntwo\nthree")
@@ -4510,6 +4521,17 @@ func TestREPLScreenVimVisualUppercaseLineOperators(t *testing.T) {
 	if screen.VimMode != VimInsert || screen.Prompt.Text != "one\nthree" || screen.Prompt.Cursor != len([]rune("one\n")) || screen.VimRegister != "two\n" || !screen.VimRegisterLinewise {
 		t.Fatalf("after visual C screen = %#v", screen)
 	}
+
+	screen = NewREPLScreen(40, 8, nil)
+	screen.SetVimEnabled(true)
+	typePromptText(&screen, "one\ntwo\nthree")
+	screen.ApplyKey(ParseKey("\x1b"))
+	for _, seq := range []string{"g", "g", "j", "v", "l", "S"} {
+		screen.ApplyKey(ParseKey(seq))
+	}
+	if screen.VimMode != VimInsert || screen.Prompt.Text != "one\nthree" || screen.Prompt.Cursor != len([]rune("one\n")) || screen.VimRegister != "two\n" || !screen.VimRegisterLinewise {
+		t.Fatalf("after visual S screen = %#v", screen)
+	}
 }
 
 func TestREPLScreenVimGLineNavigationAndOperators(t *testing.T) {

internal/tui/vim.go

@@ -396,6 +396,10 @@ func (s *REPLScreen) applyVimVisualRune(r rune) ScreenEvent {
 		s.applyVimVisualLineOperator('d')
 	case 'C':
 		s.applyVimVisualLineOperator('c')
+	case 'X':
+		s.applyVimVisualLineOperator('d')
+	case 'S':
+		s.applyVimVisualLineOperator('c')
 	case 'y', 'd', 'c':
 		s.applyVimVisualOperator(r)
 	case 'p', 'P':
@@ -1616,7 +1620,7 @@ func vimNormalCommandUsesRegister(r rune) bool {
 
 func vimVisualCommandUsesRegister(r rune) bool {
 	switch r {
-	case 'y', 'd', 'c', 'Y', 'D', 'C', 'p', 'P', 'x', 's':
+	case 'y', 'd', 'c', 'Y', 'D', 'C', 'X', 'S', 'p', 'P', 'x', 's':
 		return true
 	default:
 		return false