Skip to content

Documentation is unclear about NEXT_PUBLIC_ENABLE_EXPENSE_DOCUMENTS #603

Description

@BartschLabs

Problem: It took me quite a while to figure out I need to use NEXT_PUBLIC_ENABLE_EXPENSE_DOCUMENTS instead of ENABLE_EXPENSE_DOCUMENTS.

My Environment: I have a straightforward implementation of Spliit using the official docker image. I followed the clear instructions to use these variables:

ENABLE_EXPENSE_DOCUMENTS=true
S3_UPLOAD_KEY=AAAAAAAAAAAAAAAAAAAA
S3_UPLOAD_SECRET=AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
S3_UPLOAD_BUCKET=name-of-s3-bucket
S3_UPLOAD_REGION=us-east-1
S3_UPLOAD_ENDPOINT=http://localhost:9000

I was getting no errors in the docker container log, just no attachments functionality.

I finally looked through the PR and noticed that the variable is named NEXT_PUBLIC_ENABLE_EXPENSE_DOCUMENTS. I then searched issues for this string and saw that others were successful when they used it as the var name. I also now see the doc section on Migrating from the NEXT_PUBLIC_* variables but I don't understand if it's supposed to apply when using the official image.

Suggestion: Either change the variable name in the Expense Documents section code snippet to NEXT_PUBLIC_ENABLE_EXPENSE_DOCUMENTS or make a note in the section that it may have to be used instead of ENABLE_EXPENSE_DOCUMENTS.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions