Hotspots are properly migrated to the proper state but for some reason the hotspot review % metric is wrong

[okorach-sonar]

As you can see from the below screenshot (SQS left, SQC right), after a cloudVoyager migration all hotspots are in the correct state in SQC (0 to review, 0 ack, 0 fixed and 31 safe).
But for some reason on the source SQS the hotspot review % is 100% whereas it is only 90.3% on SQC.
The missing 9.7% look just as if 3 out of 31 would be counted as not reviewed

[joshua-quek-sonarsource]

Summary

Two hotspot sync bugs found and fixed during exhaustive regression testing:

1. || null → ?? null in syncHotspotStatus (Issue Hotspots are properly migrated to the proper state but for some reason the hotspot review % metric is wrong #146 original fix) — the early-return comparison used || which coerces all falsy values to null, instead of ?? which only treats null/undefined as nullish. Fixed across all 4 pipeline versions.

2. ACKNOWLEDGED resolution rejected by SonarCloud API (bonus bug found during regression) — SC only accepts FIXED or SAFE as resolutions, but SQ's ACKNOWLEDGED was being sent as-is. Added toScResolution() helper to map ACKNOWLEDGED→SAFE in changelog replay, and fixed the resolution mappers in all 4 pipeline versions.

Test Plan

• Regression test: created 4 reviewed SQS hotspots (1× SAFE, 3× ACKNOWLEDGED), ran full transfer to angular-test-issue-146-v3
• Before fix: Hotspot sync: 94 matched, 1 status changed — only SAFE hotspot migrated; 3 ACKNOWLEDGED failed with SC API 400 error
• After fix: Hotspot sync: 94 matched, 4 status changed, 0 failed — all 4 hotspots migrated successfully
• Phase 4 verification confirmed all 4 SQ hotspots (including 3× ACKNOWLEDGED) appear as REVIEWED/SAFE in SC

🤖 Generated with Claude Code

[joshua-quek-sonarsource]

Fixed via #154

[okorach-sonar]

Fixed !
SQS on the left, SQC on the right