Commit e2fc074
authored
fix(license): restore the MIT disclaimer, credit third-party components, ship the file (#1437)
## Description
Yes, it needed updating, on three counts.
**1. The MIT text was incomplete.** The final paragraph was missing, so
the grant carried no warranty disclaimer and no limitation of liability.
The all-caps block further down belongs to ExecuTorch's BSD notice and
is scoped to ExecuTorch. Restored the standard paragraph.
**2. The third-party list predates the rewrite.** It has not been
touched since #506. Only ExecuTorch is credited, but shipped binaries
also link:
| Component | License | Where |
| --- | --- | --- |
| pffft / FFTPACK | BSD 3-Clause | `legacy/cpp/pfft`, compiled on both
platforms |
| OpenCV 4.11 | Apache-2.0 | vision pipelines, multimodal LLMs |
| KleidiCV | Apache-2.0 | OpenCV Arm HAL, Android |
| ada | MIT | `legacy/cpp/ada` |
| phonemis | MIT | text-to-speech frontend |
| MLX | MIT | MLX backend, iOS |
pffft and the Apache-2.0 components require the notice to be reproduced
in binary redistributions, which is what an app built on this library
is. Every license identifier and copyright line above was taken from the
upstream source, not inferred.
**3. No published package shipped a license at all.** npm only packs a
`LICENSE` that sits in the package directory, and ours lives at the repo
root, so every tarball went out with `"license": "MIT"` in the manifest
and no license text. Verified with `npm pack --dry-run`: 0 matches
before, `21.8kB LICENSE` after. `create-package.sh` now copies it in for
the pack and removes it again; the three satellite packages get their
own plain MIT copy.
Left the copyright year at 2024, which is the year of first publication
and does not need bumping.
The third-party section is a judgment call about what has to be
credited, so it is worth a second opinion before merging.
### Introduces a breaking change?
- [ ] Yes
- [x] No
### Type of change
- [x] Bug fix (change which fixes an issue)
- [ ] New feature (change which adds functionality)
- [ ] Documentation update (improves or adds clarity to existing
documentation)
- [ ] Other (chores, tests, code style improvements etc.)
### Tested on
- [ ] iOS
- [ ] Android
### Testing instructions
```
cd packages/react-native-executorch
cp ../../LICENSE LICENSE && npm pack --dry-run --ignore-scripts | grep LICENSE && rm LICENSE
```
### Checklist
- [x] I have performed a self-review of my code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have updated the documentation accordingly
- [x] My changes generate no new warnings1 parent 290ba93 commit e2fc074
6 files changed
Lines changed: 453 additions & 3 deletions
File tree
- packages
- bare-resource-fetcher
- expo-resource-fetcher
- react-native-executorch-webrtc
- react-native-executorch/scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
Lines changed: 11 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
21 | 29 | | |
| 30 | + | |
22 | 31 | | |
23 | | - | |
| 32 | + | |
24 | 33 | | |
25 | 34 | | |
26 | 35 | | |
| |||
0 commit comments