Use protocol media for response negotiation.

Author: samuel-williams-shopify

lib/utopia/controller/responder.rb

@@ -5,15 +5,16 @@
 
 require_relative "middleware"
 
+require "protocol/http/header/accept"
+require "protocol/media/map"
+require "protocol/media/type"
+require "protocol/media/range"
+
 module Utopia
 	module Controller
 		module Handlers
 			module JSON
-				APPLICATION_JSON = HTTP::Accept::ContentType.new("application", "json").freeze
-				
-				def self.split(*arguments)
-					APPLICATION_JSON.split(*arguments)
-				end
+				APPLICATION_JSON = Protocol::Media::Type.new("application", "json").freeze
 
 				def self.call(context, request, media_range, object, **options)
 					if version = media_range.parameters["version"]
@@ -25,11 +26,7 @@ def self.call(context, request, media_range, object, **options)
 			end
 
 			module Passthrough
-				WILDCARD = HTTP::Accept::MediaTypes::MediaRange.new("*", "*").freeze
-				
-				def self.split(*arguments)
-					WILDCARD.split(*arguments)
-				end
+				WILDCARD = Protocol::Media::Range.new("*", "*").freeze
 
 				def self.call(context, request, media_range, object, **options)
 					# Do nothing.
@@ -39,10 +36,6 @@ def self.call(context, request, media_range, object, **options)
 
 		class Responder
 			Handler = Struct.new(:content_type, :block) do
-				def split(*arguments)
-					self.content_type.split(*arguments)
-				end
-				
 				def call(context, request, media_range, *arguments, **options)
 					context.instance_exec(media_range, *arguments, **options, &self.block)
 				end
@@ -56,7 +49,7 @@ def with(object, **options)
 			end
 
 			def initialize
-				@handlers = HTTP::Accept::MediaTypes::Map.new
+				@handlers = Protocol::Media::Map.new
 			end
 
 			attr :handlers
@@ -68,10 +61,11 @@ def freeze
 			end
 
 			def call(context, request, *arguments, **options)
-				# Parse the list of browser preferred content types and return ordered by priority:
-				media_types = HTTP::Accept::MediaTypes.browser_preferred_media_types(
-					HTTP::Accept::MediaTypes::HTTP_ACCEPT => Array(request.headers["accept"]).join(",")
-				)
+				if accept = request.headers["accept"]
+					media_types = accept.media_ranges.sort
+				else
+					media_types = [Handlers::Passthrough::WILDCARD]
+				end
 
 				handler, media_range = @handlers.for(media_types)
 
@@ -82,19 +76,22 @@ def call(context, request, *arguments, **options)
 
 			# Add a converter for the specified content type. Call the block with the response content if the request accepts the specified content_type.
 			def handle(content_type, &block)
-				@handlers << Handler.new(content_type, block)
+				@handlers[content_type] = Handler.new(content_type, block)
+				return @handlers
 			end
 
 			def respond_to(context, request)
 				Responds.new(self, context, request)
 			end
 
 			def with_json
-				@handlers << Handlers::JSON
+				@handlers[Handlers::JSON::APPLICATION_JSON] = Handlers::JSON
+				return @handlers
 			end
 
 			def with_passthrough
-				@handlers << Handlers::Passthrough
+				@handlers[Handlers::Passthrough::WILDCARD] = Handlers::Passthrough
+				return @handlers
 			end
 
 			def with(content_type, &block)

test/utopia/controller/respond.rb

@@ -83,6 +83,12 @@ def mock_request(path, headers = {})
 		expect(response.read).to be == '{"user_id":10}'
 	end
 
+	it "can register a passthrough handler" do
+		responder = Utopia::Controller::Responder.new
+		
+		expect(responder.with_passthrough).to be == responder.handlers
+		expect(responder.handlers["*/*"]).to be == Utopia::Controller::Handlers::Passthrough
+	end
 end
 
 describe Utopia::Controller do

utopia.gemspec

@@ -35,6 +35,7 @@ Gem::Specification.new do |spec|
 	spec.add_dependency "msgpack"
 	spec.add_dependency "net-smtp"
 	spec.add_dependency "protocol-http", "~> 0.58"
+	spec.add_dependency "protocol-media", "~> 0.1"
 	spec.add_dependency "protocol-url", "~> 0.4"
 	spec.add_dependency "samovar", "~> 2.1"
 	spec.add_dependency "traces", "~> 0.10"