Make ruler shape used for file names configurable

[mzimnn]

Commit a72243f introduced a new ruler shape box which is now used to display file names. However, I would like to use the traditional ruler shape ruler for file names.

Would it be possible to make it configurable which ruler shape should be used for file names? For example a new option fileNameRulerShape could be added which can be set to either box or ruler.

[scottchiefbaker]

I'm hesitant to add new configuration options for every little thing. For now you can emulate the old behaviour by changing:

sub draw_ruler {
    my ($str, $type, $color) = @_;

    $str     = trim($str);
    $type  ||= 'ruler';

to

sub draw_ruler {
    my ($str, $type, $color) = @_;

    $str  = trim($str);
    $type = 'ruler';

[mzimnn]

Thanks for the workaround, this solves it for now.

To provide some context on why I prefer the traditional ruler over the boxes:

The width of the boxes varies depending on the length of the file name. On the other hand, the traditional ruler always uses the full width of the terminal and therefore looks consistent and not "jagged" like the boxes.

Have a look at this (more extreme) example from this commit:

Current version:

Old version:

As a side note: I actually always preferred diff-so-fancy over delta since it didn't use these boxes.

If you're willing to consider it, I'd be happy to take a look at it and open a pull request.

[scottchiefbaker]

If you want to write up a PR I'd be willing to consider it. It should include both implementation code, and documentation.

[artem-nefedov]

btw screenshot in readme still shows old rulers

[scottchiefbaker]

For normal git diff syntax the rulers shouldn't change. They only become boxes when in git show mode. Or am I missing something?

[artem-nefedov]

For normal git diff syntax the rulers shouldn't change. They only become boxes when in git show mode. Or am I missing something?

no, you're right, I didn't realize the distinction between diff and show

[scottchiefbaker]

There would have been riots in the streets if I changed the default for git diff