[Legacy Bug] CTD when I entered "Whose dreams were shattered here" cutscene after changing resolution

[thekovic]

To reproduce:

1. Load Nub's Tomb
2. Change game resolution
3. Enter cutscene

[smlu]

I can reproduce this error also on vanilla .exe version 1.2. More testing is needed but I think it might be COG script related.

[smlu]

I dig into this issue and tldr; it's a bug in the nub_opencutscene.cog script.

In nub_opencutscene.cog line 113 the cinematic camera is set via call to SetCurrentCamera(2) but the focus for this camera is set in the code following this call. That's wrong as SetCurrentCamera function expects camera focus to be set prior to call.

How bug is triggered: In user0 message handler the cinematic camera focus thing is set for intro cutscene. If screen resolution is not changed the camera will retain the focus and triggering the 2nd intro cutscene won't crash the game. But if the screen resolution is changed between the cutscenes the camera's focus will be removed leading to a game crash when 2nd cutscene is triggered, due to the bug described above.

To resolve this issue the intro script would have to be updated and move the call to SetCameraFocus(2, camera) after the call to SetCameraSecondaryFocus(2, actor), like so:

SetCameraFocus(2, camera);
SetCameraSecondaryFocus(2, actor);
SetCurrentCamera(2);
SetCameraFOV(90, 0, 0.0);

Side Note: Engine could also better handle restart of JonesDisplay and cache & re-assign the focused things to cameras in JonesDisplay_Restart.