Merge branch 'main' into ale-manifest-source-flag

Author: srtaalej

.circleci/config.yml

@@ -109,7 +109,7 @@ jobs:
         default: "dev-build"
     docker: # run the steps with Docker
       # CircleCI Go images available at: https://hub.docker.com/r/circleci/golang/
-      - image: cimg/go:1.26.6
+      - image: cimg/go:1.27.1
     steps: # steps that comprise the `build` job
       - checkout # check out source code to working directory
       - restore_cache: # restores saved cache if no changes are detected since last run

.github/MAINTAINERS_GUIDE.md

@@ -192,7 +192,8 @@ pkg/
 
 ### `scripts/`
 
-Installation and setup scripts for various operating systems are available here.
+Installation and setup scripts for various operating systems are available here,
+along with scripts that support the release process.
 
 ### `test/`
 
@@ -526,15 +527,20 @@ For these changes to complete, certain application permissions are needed:
 
 - **Actions**: Read and write
 - **Contents**: Read and write
+- **Issues**: Read and write
 - **Metadata**: Read
 - **Pull requests**: Read and write
 - **Workflows**: Read and write
 
+The **Issues** permission is needed to create, rename, and close milestones.
+Note that adding a permission to the app is not enough on its own, since each
+existing installation must also be granted the new permission.
+
 Access to this project is also required with the selected application scopes.
 
 Credentials and secrets for the app can be stored as the following variables:
 
-- `GH_APP_ID_RELEASER`
+- `GH_APP_CLIENT_ID_RELEASER`
 - `GH_APP_PRIVATE_KEY_RELEASER`
 
 #### Bumping Go package versions
@@ -800,7 +806,16 @@ Steps to triage a pull request:
 4. **Milestone**:
    - A milestone should be assigned when possible, usually as the `Next Release`
    - After a release, the `Next Release` milestone is renamed to the tagged
-     version
+     version and closed, while a new `Next Release` milestone gathers the issues
+     and pull requests that remain open
+   - This happens automatically with [this workflow][wf-milestone] when a
+     production release is published, but can also be done by hand:
+     ```sh
+     $ DRY_RUN=true ./scripts/triage-milestone.sh v4.8.0
+     $ ./scripts/triage-milestone.sh v4.8.0
+     ```
+   - The `Next Release` milestone must keep this exact name because release and
+     dependency automation assigns pull requests to it by title
 
 #### Pull request: merge
 
@@ -853,3 +868,4 @@ When in doubt, find the other maintainers and ask.
 [sync]: https://github.com/slackapi/slack-cli/blob/main/.github/workflows/sync-docs-from-cli-repo.yml
 [vscode]: https://github.com/slackapi/slack-cli/blob/main/.vscode/settings.json
 [wf-dependencies]: ./workflows/dependencies.yml
+[wf-milestone]: ./workflows/milestone.yml

.github/workflows/license_check.yml

@@ -17,6 +17,6 @@ jobs:
         with:
           persist-credentials: false
       - name: Check license headers
-        uses: apache/skywalking-eyes@61275cc80d0798a405cb070f7d3a8aaf7cf2c2c1 # v0.8.0
+        uses: apache/skywalking-eyes@a196742f472feaffafea537ce5a2a4c3c53a8de4 # v0.9.0
         with:
           config: .licenserc.yml

.github/workflows/milestone.yml

@@ -0,0 +1,60 @@
+name: Milestone
+
+on:
+  release:
+    types:
+      - published
+  workflow_dispatch:
+    inputs:
+      tag:
+        description: The release tag to triage
+        required: true
+        type: string
+
+concurrency: ${{ github.workflow }}
+
+jobs:
+  triage:
+    name: Triage Milestone
+    # Development and feature builds are published as prereleases by CircleCI
+    if: >-
+      github.event_name == 'workflow_dispatch' ||
+      (github.event.release.prerelease == false && github.event.release.draft == false)
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+    steps:
+      - name: Gather credentials
+        id: credentials
+        uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
+        with:
+          client-id: ${{ secrets.GH_APP_CLIENT_ID_RELEASER }}
+          private-key: ${{ secrets.GH_APP_PRIVATE_KEY_RELEASER }}
+
+      - name: Checkout repo
+        uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+        with:
+          persist-credentials: false
+
+      - name: Decide the release tag
+        id: release
+        env:
+          TAG: ${{ inputs.tag || github.event.release.tag_name }}
+        run: |
+          if [[ ! "$TAG" =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
+            echo "The $TAG tag is not a production release, nothing to triage"
+            echo "should_triage=false" >> "$GITHUB_OUTPUT"
+            exit 0
+          fi
+
+          echo "should_triage=true" >> "$GITHUB_OUTPUT"
+          echo "tag=$TAG" >> "$GITHUB_OUTPUT"
+          echo "Triaging the milestone of $TAG"
+
+      - name: Triage the milestone
+        if: steps.release.outputs.should_triage == 'true'
+        env:
+          GH_TOKEN: ${{ steps.credentials.outputs.token }}
+          REPO: ${{ github.repository }}
+          TAG: ${{ steps.release.outputs.tag }}
+        run: ./scripts/triage-milestone.sh "$TAG"

.github/workflows/tests.yml

@@ -20,20 +20,42 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
         with:
-          go-version: "1.26.6"
+          go-version: "1.27.1"
       - name: Lint
         run: go tool golangci-lint run --timeout=5m
       - name: Unit Tests
         run: make test
-      - name: Install Tests
-        run: make test-install
       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
           files: ./coverage.out
           fail_ci_if_error: false
 
+  install-tests:
+    name: Install Tests
+    strategy:
+      fail-fast: false
+      matrix:
+        os:
+          - macos-latest
+          - ubuntu-latest
+          - windows-latest
+    runs-on: ${{ matrix.os }}
+    permissions:
+      contents: read
+    steps:
+      - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
+        with:
+          persist-credentials: false
+      - name: Install Tests (Unix)
+        if: runner.os != 'Windows'
+        run: make test-install
+      - name: Install Tests (Windows)
+        if: runner.os == 'Windows'
+        shell: pwsh
+        run: ./scripts/install-windows-test.ps1
+
   # Monitor code coverage and TODO/FIXME-type comments
   health-score:
     name: Health Score
@@ -49,7 +71,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
         with:
-          go-version: "1.26.6"
+          go-version: "1.27.1"
       - name: Report health score
         uses: slackapi/slack-health-score@d58a419f15cdaff97e9aa7f09f95772830ab66f7 # v0.1.1
         with:

cmd/app/app.go

@@ -52,6 +52,7 @@ func NewCommand(clients *shared.ClientFactory) *cobra.Command {
 	cmd.AddCommand(NewDeleteCommand(clients))
 	cmd.AddCommand(NewLinkCommand(clients))
 	cmd.AddCommand(NewListCommand(clients))
+	cmd.AddCommand(NewRequestCommand(clients))
 	cmd.AddCommand(NewSettingsCommand(clients))
 	cmd.AddCommand(NewUninstallCommand(clients))
 	cmd.AddCommand(NewUnlinkCommand(clients))