Skip to content

[ENH] Adding Support of Distribution Loss in v2 Models. #2389

Description

@Muhammad-Rebaal

Is your feature request related to a problem? Please describe.
Currently there isn't any support of Distribution Loss in v2 models

Describe the solution you'd like
The V2 BaseModel _base_model_v2.py should detect when the passed loss is a DistributionLoss from metrics/distributions.py and automatically infer output_size from len(loss.distribution_arguments), call loss.rescale_parameters() in the training loop, and ensure target_scale is passed through from the V2 DataModule batch the full DistributionLoss contract map_x_to_distribution, to_quantiles, sample is already implemented and only needs to be wired into the V2 model layer.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions