Skip to content

Feedback notes #30

Description

@v-lawsie

Hello 👋 , I'm a new contractor working on Britni's team. I've been enjoying working through some of your content as part of my onboarding tasks, I really like the interactive format. While I was completing the exercise I came across a few issues so I'm hoping it's helpful to provide my notes 😃 (please just say if you'd prefer I didn't or there's a better way to do this - absolutely not wishing to tread on anyone's toes).

Step 1

  • I initially got really confused by

Before we implement automated code reviews with Copilot, it makes sense to try reviews locally in VS Code.

...because I started up the codespace and then I thought I was supposed to do the following steps in the VS Code installed on my computer which to me was locally(!) I then realised in step 4 (refresh the running app) that what you actually meant was to do it in the VS Code in the codespace otherwise it wasn't then possible to do the rest without pushing to remote 🤦‍♀️

  • The copilot extension looks like it's been replaced with a newer one(?) Screenshot attached in case its helpful to drop in.
Image
  • On step 6 of the activity, I got stuck for ages because the button to request review wasn't there but I knew I had enterprise credits and I'd checked code review was enabled. It turns out that most of the codespace was authenticated as me, but I also needed to authenticate again in the chat window for the enterprise bit which was a bit of a gotcha.

  • On step 8, no matter what I did, the apply button was always greyed out. I even tried adding a fake API key and requesting a review and it still had no suggestions. I didn't figure out why this happened, not sure what was wrong. I had to discard everything, and then of course it all came up again in the PR review.

Image

Step 3

  • I don't know if this is deliberate to generate something for Copilot to have a look at or not (so if it is, please ignore!) but Copilot had opinions about the front and backend guidelines:
Image Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status
    Needs Triage

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions