DEVEXP-928: Match Generated Code

Author: matsk-sinch

sinch/domains/numbers/api/v1/available_numbers_apis.py

@@ -70,7 +70,7 @@ def rent(
     def rent_any(
         self,
         region_code: StrictStr,
-        type_: NumberTypeValues,
+        number_type: NumberTypeValues,
         number_pattern: Optional[NumberPatternDict] = None,
         capabilities: Optional[conlist(CapabilityTypeValues)] = None,
         sms_configuration: Optional[SmsConfigurationDict] = None,
@@ -80,7 +80,7 @@ def rent_any(
     ) -> ActiveNumber:
         request_data = RentAnyNumberRequest(
             region_code=region_code,
-            type_=type_,
+            number_typetype_=number_type,
             number_pattern=number_pattern,
             capabilities=capabilities,
             sms_configuration=sms_configuration,

sinch/domains/numbers/api/v1/base/__init__.py

@@ -1,3 +1,3 @@
-from sinch.domains.numbers.api.v1.base.base_numbers import BaseNumbers as BaseNumbers
+from sinch.domains.numbers.api.v1.base.base_numbers import BaseNumbers
 
 __all__ = ['BaseNumbers']

sinch/domains/numbers/models/v1/internal/rent_any_number_request.py

@@ -7,7 +7,7 @@
 
 class RentAnyNumberRequest(BaseModelConfigurationRequest):
     region_code: StrictStr = Field(alias="regionCode")
-    type_: NumberType = Field(alias="type")
+    number_type: NumberType = Field(alias="type")
     number_pattern: Optional[Dict[str, Any]] = Field(default=None, alias="numberPattern")
     capabilities: Optional[conlist(CapabilityType)] = Field(default=None)
     sms_configuration: Optional[Dict[str, Any]] = Field(default=None, alias="smsConfiguration")

sinch/domains/numbers/virtual_numbers.py

@@ -181,7 +181,8 @@ def update(
             display_name=display_name,
             sms_configuration=sms_configuration,
             voice_configuration=voice_configuration,
-            callback_url=callback_url, **kwargs
+            callback_url=callback_url,
+            **kwargs
         )
 
     def get(
@@ -320,10 +321,10 @@ def rent(
     def rent_any(
         self,
         region_code: StrictStr,
-        type_: NumberTypeValues,
+        number_type: NumberTypeValues,
         sms_configuration: SmsConfigurationDict,
         voice_configuration: VoiceConfigurationRTCDict,
-        number_pattern: Optional[NumberPatternDict] = None,
+        number_pattern: NumberPatternDict,
         capabilities: Optional[CapabilityTypeValues] = None,
         callback_url: Optional[StrictStr] = None
     ) -> ActiveNumber:
@@ -333,10 +334,10 @@ def rent_any(
     def rent_any(
         self,
         region_code: StrictStr,
-        type_: NumberTypeValues,
+        number_type: NumberTypeValues,
         sms_configuration: SmsConfigurationDict,
         voice_configuration: VoiceConfigurationFAXDict,
-        number_pattern: Optional[NumberPatternDict] = None,
+        number_pattern: NumberPatternDict,
         capabilities: Optional[conlist(CapabilityTypeValues)] = None,
         callback_url: Optional[StrictStr] = None
     ) -> ActiveNumber:
@@ -346,10 +347,10 @@ def rent_any(
     def rent_any(
         self,
         region_code: StrictStr,
-        type_: NumberTypeValues,
+        number_type: NumberTypeValues,
         sms_configuration: SmsConfigurationDict,
         voice_configuration: VoiceConfigurationESTDict,
-        number_pattern: Optional[NumberPatternDict] = None,
+        number_pattern: NumberPatternDict,
         capabilities: Optional[conlist(CapabilityTypeValues)] = None,
         callback_url: Optional[StrictStr] = None
     ) -> ActiveNumber:
@@ -358,7 +359,7 @@ def rent_any(
     def rent_any(
         self,
         region_code: StrictStr,
-        type_: NumberTypeValues,
+        number_type: NumberTypeValues,
         number_pattern: Optional[NumberPatternDict] = None,
         capabilities: Optional[conlist(CapabilityTypeValues)] = None,
         sms_configuration: Optional[SmsConfigurationDict] = None,
@@ -373,10 +374,14 @@ def rent_any(
         :param region_code: ISO 3166-1 alpha-2 country code of the phone number.
         :type region_code: str
 
-        :param type_: Type of number (e.g., ``"MOBILE"``, ``"LOCAL"``, ``"TOLL_FREE"``). Defaults to ``"MOBILE"``.
-        :type type_: NumberType
+        :param number_type: Type of number (e.g., ``"MOBILE"``, ``"LOCAL"``, ``"TOLL_FREE"``). Defaults to ``"MOBILE"``.
+        :type number_type: NumberTypeValues
 
-        :param number_pattern: Specific sequence of digits to search for.
+        :param number_pattern: A dictionary defining the specific sequence of digits to search for.
+        Include fields such as::
+                                    - ``pattern`` (str): The specific sequence of digits.
+                                    - ``search_pattern`` (str):
+                                            The pattern to apply (e.g., ``"START"``, ``"CONTAINS"``, ``"END"``).
         :type number_pattern: Optional[NumberPatternDict]
 
         :param capabilities: Capabilities required for the number (e.g., ``["SMS", "VOICE"]``).
@@ -408,7 +413,7 @@ def rent_any(
         """
         return self._available.rent_any(
             region_code=region_code,
-            type_=type_,
+            number_type=number_type,
             number_pattern=number_pattern,
             capabilities=capabilities,
             sms_configuration=sms_configuration,

tests/unit/domains/numbers/v1/endpoints/available/test_rent_any_number_endpoint.py

@@ -14,7 +14,7 @@ def valid_request_data():
     """
     return RentAnyNumberRequest(
         region_code="US",
-        type_="MOBILE",
+        number_type="MOBILE",
         number_pattern={"pattern": "string", "searchPattern": "START"},
         capabilities=["SMS"],
         sms_configuration={"servicePlanId": "string", "campaignId": "string"},

tests/unit/domains/numbers/v1/models/internal/test_list_available_numbers_request_model.py

@@ -108,7 +108,7 @@ def test_list_available_numbers_expects_parsed_extra_field_snake_case():
     }
     response = ListAvailableNumbersRequest(**data)
 
-    # Assert known fields
+    # Assert unknown fields
     assert response.extraField == "Extra Value"
 
 
@@ -125,13 +125,13 @@ def test_list_available_numbers_expects_snake_case_to_parsed_extra_field_snake_c
     }
     response = ListAvailableNumbersRequest(**data)
 
-    # Assert known fields
+    # Assert unknown fields
     assert response.extra_field == "Extra Value"
 
 
 def test_list_available_numbers_expects_extra_capability():
     """
-    Expects unrecognized fields to be dynamically added as snake_case attributes.
+    Expects unrecognized value to be added.
     """
     data = {
         "number_type": "MOBILE",
@@ -142,5 +142,5 @@ def test_list_available_numbers_expects_extra_capability():
     }
     response = ListAvailableNumbersRequest(**data)
 
-    # Assert known fields
+    # Assert ex fields
     assert response.capabilities == ["SMS", "VOICE", "EXTRA"]

tests/unit/domains/numbers/v1/models/internal/test_rent_any_number_request_model.py

@@ -31,7 +31,7 @@ def test_rent_any_number_request_expects_valid_data():
         "searchPattern": "START"
         }
     assert request.region_code == "string"
-    assert request.type_ == "MOBILE"
+    assert request.number_type == "MOBILE"
     assert request.capabilities == ["SMS"]
     assert request.sms_configuration == {
             "servicePlanId": "string",
@@ -56,7 +56,7 @@ def test_rent_any_number_request_expects_missing_optional_fields():
     request = RentAnyNumberRequest(**data)
 
     assert request.region_code == "string"
-    assert request.type_ == "MOBILE"
+    assert request.number_type == "MOBILE"
 
     assert request.number_pattern is None
     assert request.capabilities is None