Skip to content

## Pull Request Overview #24

Description

@silentius-satoshi

Pull Request Overview

This PR integrates Bitcoin Connect Lightning wallet support into the ZapTok app by introducing context, components, and UI updates to manage connections and send zaps.

  • Added WalletContext and WalletProvider to manage WebLN/Bitcoin Connect wallet state and operations.
  • Created WalletConnect and ZapButton components for wallet UI and NIP-57 zap flows.
  • Updated Settings page, navigation menu, video action buttons, router, and app provider to include wallet and zap functionality.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/contexts/WalletContext.tsx New context/provider for wallet connection, payment, balance, and invoice APIs
src/components/WalletConnect.tsx UI component to connect/disconnect a Lightning wallet
src/components/ZapButton.tsx Component to compose and send zaps with comment dialog
src/pages/Settings.tsx Settings page with account and wallet cards
src/components/VideoActionButtons.tsx Inserted ZapButton between like and comment buttons
src/components/Navigation.tsx Added Settings link with routing and gradient styling
src/AppRouter.tsx Registered /settings route
src/App.tsx Wrapped the app in WalletProvider
Comments suppressed due to low confidence (4)

src/contexts/WalletContext.tsx:53

  • [nitpick] The connect function currently throws an error placeholder when no WebLN provider is found. Consider adding a clear // TODO comment and extracting this logic into a named function or constant so it’s easier to implement Bitcoin Connect integration later.
  const connect = async () => {

src/components/ZapButton.tsx:121

  • [nitpick] getZapEndpoint is a placeholder that always returns null. Add a // TODO or JSDoc block explaining that this must be implemented to fetch the user’s profile and extract their Lightning address before shipping.
  const getZapEndpoint = async (pubkey: string): Promise<string | null> => {

src/contexts/WalletContext.tsx:1

  • The core wallet logic (connect, disconnect, sendPayment, getBalance, makeInvoice) is critical and lacks unit tests. Add tests to cover success and failure paths for each method.
import { createContext, useContext, useEffect, useState, ReactNode } from 'react';

src/components/ZapButton.tsx:30

  • The ZapButton’s handleZap contains multiple async steps (endpoint fetch, invoice creation, payment, event publish). Add unit or integration tests to cover cases like missing wallet, endpoint failures, and successful zaps.
  const handleZap = async () => {

Originally posted by @Copilot in #23 (review)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions