From 365628935d82d1699ae505bc26557502052e15d4 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Fri, 19 Jun 2026 11:59:34 +0000
Subject: [PATCH] Improve installer template testability (accessibility-first)

Make the installer reliably targetable from acceptance tests while
preferring accessible locators over test-only hooks:

- Fix the PHP binary field's broken label association (the <label> used
  for="name" but no matching id existed), so the input is reachable via
  an accessible label locator instead of needing a test id.
- Add data-testid only to the streamed log <pre> elements on the
  install and update pages, which have no role, accessible name or
  stable text and therefore cannot be located accessibly.

Everything else (buttons, links, headings, labeled selects, visible
text, alerts) is already reachable through role/label/text locators, so
no test ids were added there. All 85 existing tests pass.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TJMFV7jMT6L1Re9DPQtfwF
---
 Resources/views/install.html.twig    | 2 +-
 Resources/views/php_config.html.twig | 4 ++--
 Resources/views/update.html.twig     | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Resources/views/install.html.twig b/Resources/views/install.html.twig
index 5f5055f..f0c73a7 100644
--- a/Resources/views/install.html.twig
+++ b/Resources/views/install.html.twig
@@ -35,7 +35,7 @@
         <div class="alert alert-error" id="log-error" style="display: none">{{ 'shopware.update.steps.install.error'|trans|raw }}</div>
 
         <div id="log-card" style="display: none;">
-            <pre class="form-control" id="log-output" style="height: 60vh;"></pre>
+            <pre class="form-control" id="log-output" style="height: 60vh;" data-testid="install-log-output"></pre>
         </div>
 
     </div>
diff --git a/Resources/views/php_config.html.twig b/Resources/views/php_config.html.twig
index dd41b51..3cf8dde 100644
--- a/Resources/views/php_config.html.twig
+++ b/Resources/views/php_config.html.twig
@@ -10,8 +10,8 @@
 
         <form method="POST" id="submit">
             <div class="form-group">
-                <label for="name">{{ 'shopware.update.steps.configure_php.pathInput'|trans }}</label>
-                <input class="form-control" type="text" name="phpBinary" value="{{ phpBinary }}">
+                <label for="phpBinary">{{ 'shopware.update.steps.configure_php.pathInput'|trans }}</label>
+                <input class="form-control" type="text" id="phpBinary" name="phpBinary" value="{{ phpBinary }}">
             </div>
         </form>
     </div>
diff --git a/Resources/views/update.html.twig b/Resources/views/update.html.twig
index 70b056c..377663e 100644
--- a/Resources/views/update.html.twig
+++ b/Resources/views/update.html.twig
@@ -31,7 +31,7 @@
             <div class="card-body">
                 <h5 class="card-title">{{ 'shopware.update.steps.update.log'|trans }}</h5>
 
-                <pre class="form-control" id="log-output" style="height: 60vh"></pre>
+                <pre class="form-control" id="log-output" style="height: 60vh" data-testid="update-log-output"></pre>
             </div>
         </div>
     </div>