fix: 22 defects found by an adversarial review of the eight features

Every one was verified by a second pass that tried to refute it. Ordered by
what they cost.

SENDING A TRUNCATED MESSAGE, AND LOSING THE REST. The collision toast's "Send"
action called the `submit` closure captured when the warning was raised. Sonner
freezes that handler, so eight seconds of further typing was invisible to it:
it sent the older text, then cleared the field AND reset the draft dirty-check,
so the rest was destroyed in the composer and deleted server-side. It now goes
through a ref that always points at the current render.

THE COLLISION WARNING COULD SILENTLY DISARM ITSELF. The acknowledged flag was
set by SHOWING the warning rather than by acknowledging it, and never reset —
so ignoring one toast suppressed the confirmation for the next send, including
in a different conversation, since the composer instance is reused across
routes.

CITATIONS POINTED AT THE WRONG SOURCES. The answer says [3]; the source list
renumbered from 1. Every reference was off, which is worse than showing no
sources, because the entire promise of the feature is that you can check it.
Sources are now keyed by the number the model actually used, and each shows the
excerpt that was cited rather than the highest-ranked one in that conversation.

A SAVED VIEW OPENED UNFILTERED. viewHref never emitted the new `seen` or `has`
params, so a saved view built on either one showed everything while its sidebar
badge counted the filtered set.

CONTACT-NAME RETRIEVAL NEVER FIRED. `displayName % question` compares a short
name against a whole sentence with length-normalised trigram similarity, which
never clears the threshold. "What did Sarah say about the deposit" therefore
never looked at Sarah's conversations at all. Now matched word by word, with
stop words removed.

A YEAR PARSED AS A CLOCK TIME. "mar 4 2026" — the time regex took "2026" as
20:26. And in "mar 9:30" the day matcher rejected the 9 for having a colon,
then accepted the 30 as the day of the month.

PROTOTYPE KEYS RESOLVED AS WEEKDAYS. `'constructor' in WEEKDAYS` is true, so
"in 5 constructor" produced an Invalid Date that threw downstream in
toISOString(). The lookup tables are null-prototype now.

READ-NO-REPLY COUNTED OUR OWN TAPBACKS. An agent's reaction was treated as "a
message they read and ignored", flagging conversations where we owed the reply.

THE GHOST TEXT DID NOT LINE UP. The Textarea base carries `md:text-sm`, which
twMerge keeps alongside `text-[13.5px]` — so above 768px the real text was 14px
and the ghost 13.5px. A completion that wrapped was also clipped out of sight
while Tab still accepted all of it; the field now grows to fit it.

FIND COUNTED HITS IT COULD NOT SHOW YOU. System events and tapbacks matched,
but they render as centred pills with no ref and no highlighting, so those
stops scrolled nowhere. Overlapping matches were counted but collapsed by the
highlighter, making "3 of 5" a lie; the matcher and the renderer now agree, and
a test asserts they always will.

Also: the note/reply toggle was dropped by the pagehide flush, which compared
only the body — the one mechanism that exists to cover the debounce window
would have turned an internal note into a public reply. The date picker
committed on every keystroke that happened to form a valid value, discarded
past times with no feedback, and had no `min`. The person panel's primary
address had no ORDER BY, so an email sorting first silently removed the local
time.

9 new tests, 205 total.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RuKkB7AfSNCcwvubV99pDU

Author: claude

apps/web/src/app/(app)/layout.tsx

@@ -43,6 +43,8 @@ export default async function AppLayout({ children }: { children: React.ReactNod
       p.set('priority', f.priorityIn.join(','));
     if (f.slaBreached) p.set('sla', 'breached');
     if (f.unreadOnly) p.set('unread', '1');
+    if (f.readNoReply) p.set('seen', '1');
+    if (f.has) p.set('has', String(f.has));
     if (f.sort && f.sort !== 'newest') p.set('sort', String(f.sort));
     const qs = p.toString();
     return qs ? `/inbox?${qs}` : '/inbox';

apps/web/src/components/inbox/ask-archive.tsx

@@ -120,16 +120,16 @@ export function AskArchive() {
                 From these conversations
               </p>
               <div className="divide-y rounded-xl border">
-                {sources.map((s, i) => (
+                {sources.map((s) => (
                   <Link
-                    key={s.conversationId}
+                    key={s.index}
                     href={`/inbox/${s.conversationId}`}
                     className={cn(
                       'flex items-start gap-2.5 px-3 py-2.5 transition-colors hover:bg-accent/60',
                     )}
                   >
                     <span className="type-caption tabular mt-0.5 shrink-0 text-muted-foreground/60">
-                      [{i + 1}]
+                      [{s.index}]
                     </span>
                     <span className="min-w-0">
                       <span className="type-title block truncate">{s.conversationName}</span>

apps/web/src/components/inbox/composer.tsx

@@ -77,8 +77,10 @@ export function Composer({
   const [pending, start] = useTransition();
   const ref = useRef<HTMLTextAreaElement>(null);
   const lastTypingPing = useRef(0);
-  /** Set once the user has acknowledged a collision, so we ask only once. */
+  /** Set once the user has ACKNOWLEDGED a collision, so we ask only once. */
   const confirmedCollision = useRef(false);
+  /** Always the current render's submit — see the collision toast. */
+  const submitRef = useRef<(scheduledFor?: Date) => void>(() => {});
   /** Inline completion shown after the caret; Tab accepts it. */
   const [completion, setCompletion] = useState('');
   const ghostRef = useRef<HTMLDivElement>(null);
@@ -129,6 +131,9 @@ export function Composer({
     loadedFor.current = conversationId;
     setBody(initialDraft?.body ?? '');
     setIsNote(initialDraft?.isPrivateNote ?? false);
+    // Acknowledging a collision in one conversation must not disarm the
+    // warning in the next one.
+    confirmedCollision.current = false;
   }, [conversationId, initialDraft]);
 
   /**
@@ -155,7 +160,7 @@ export function Composer({
   // draft would hurt most. keepalive lets the request outlive the page.
   useEffect(() => {
     const flush = () => {
-      if (body === savedBody.current) return;
+      if (body === savedBody.current && isNote === savedIsNote.current) return;
       navigator.sendBeacon?.(
         '/api/drafts',
         new Blob([JSON.stringify({ conversationId, body, isPrivateNote: isNote })], {
@@ -214,8 +219,14 @@ export function Composer({
     const el = ref.current;
     if (!el) return;
     el.style.height = 'auto';
-    el.style.height = `${Math.min(el.scrollHeight, 180)}px`;
-  }, [body]);
+    // Measured against the GHOST as well: a completion that wraps onto a new
+    // line would otherwise be clipped out of sight while Tab still accepted it.
+    const needed = Math.max(el.scrollHeight, ghostRef.current?.scrollHeight ?? 0);
+    el.style.height = `${Math.min(needed, 180)}px`;
+    // A ghost that mounts while the field is already scrolled must start at the
+    // same offset; the scroll event alone never fires in that case.
+    syncGhostScroll();
+  }, [body, completion]);
 
   function submit(scheduledFor?: Date) {
     const trimmed = body.trim();
@@ -224,10 +235,19 @@ export function Composer({
     // Confirm rather than block. The person at the keyboard may know exactly
     // what they are doing — but they should have to say so, once.
     if (typingPeers.length > 0 && !isNote && !confirmedCollision.current) {
-      confirmedCollision.current = true;
       toast.warning(`${firstNames(typingPeers)} is also replying`, {
         description: 'Send anyway?',
-        action: { label: 'Send', onClick: () => submit(scheduledFor) },
+        action: {
+          label: 'Send',
+          // Through a ref, NOT the captured `submit`. Sonner freezes the
+          // handler at raise time, so calling the closure directly sent the
+          // body as it was when the toast appeared and discarded everything
+          // typed during the eight seconds it was on screen.
+          onClick: () => {
+            confirmedCollision.current = true;
+            submitRef.current(scheduledFor);
+          },
+        },
         duration: 8000,
       });
       return;
@@ -249,6 +269,10 @@ export function Composer({
     });
   }
 
+  // Rebound every render so the collision toast, which captured its handler
+  // once, always reaches the current body.
+  submitRef.current = submit;
+
   /** Insert a macro: render its variables server-side and run its actions. */
   function pickMacro(m: MacroOption) {
     start(async () => {
@@ -499,7 +523,7 @@ export function Composer({
               <div
                 ref={ghostRef}
                 aria-hidden
-                className="pointer-events-none absolute inset-0 max-h-[180px] overflow-hidden whitespace-pre-wrap break-words px-1.5 py-1.5 text-[13.5px] leading-[inherit]"
+                className="pointer-events-none absolute left-0 right-0 top-0 max-h-[180px] overflow-hidden whitespace-pre-wrap break-words px-1.5 py-1.5 text-[13.5px] leading-[inherit] md:text-[13.5px]"
               >
                 <span className="invisible">{body}</span>
                 <span className="text-muted-foreground/50">{completion}</span>
@@ -520,7 +544,7 @@ export function Composer({
                   ? 'Type a message…  ⇥ to accept the suggested reply'
                   : 'Type a message…  /  for macros'
             }
-            className="relative max-h-[180px] min-h-[38px] w-full resize-none border-0 bg-transparent px-1.5 py-1.5 text-[13.5px] shadow-none focus-visible:ring-0"
+            className="relative max-h-[180px] min-h-[38px] w-full resize-none border-0 bg-transparent px-1.5 py-1.5 text-[13.5px] shadow-none focus-visible:ring-0 md:text-[13.5px]"
             rows={1}
           />
           </div>

apps/web/src/components/inbox/filter-bar.tsx

@@ -154,6 +154,7 @@ export function FilterBar({
           slaBreached: filters.slaBreached || undefined,
           unreadOnly: filters.unreadOnly || undefined,
           readNoReply: filters.readNoReply || undefined,
+          has: filters.has as never,
           sort: filters.sort as never,
         },
       });

apps/web/src/components/inbox/message-thread.tsx

@@ -234,6 +234,9 @@ export function MessageThread({
     const out: FindMatch[] = [];
     for (const m of messages) {
       if (!m.body) continue;
+      // System events and tapbacks render as centred pills with no ref and no
+      // highlighting, so counting them produced hits that scrolled nowhere.
+      if (m.authorType === 'system' || m.reactionType) continue;
       for (const offset of findOffsets(m.body, q)) out.push({ messageId: m.id, offset });
     }
     return out;

apps/web/src/components/inbox/time-picker.tsx

@@ -35,9 +35,31 @@ export function CustomTimePicker({
   const parsed = useMemo(() => (text.trim() ? parseNaturalTime(text) : null), [text]);
   const invalid = text.trim().length > 0 && !parsed;
 
+  const [exact, setExact] = useState('');
+  const [pickerError, setPickerError] = useState<string | null>(null);
+
   function commit() {
     const at = parseNaturalTime(text);
+    // Re-parsed at commit so "in 3 hours" means three hours from now, not from
+    // when it was typed. If that now fails, say so rather than doing nothing
+    // while the line above still shows the old successful reading.
     if (at) onPick(at);
+    else if (text.trim()) setPickerError("Couldn't read that — try “tue 9am”");
+  }
+
+  function commitExact() {
+    if (!exact) return;
+    const at = new Date(exact);
+    if (Number.isNaN(at.getTime())) {
+      setPickerError('That is not a valid date.');
+      return;
+    }
+    if (at.getTime() <= Date.now()) {
+      // Silently dropping a past value made the control look broken.
+      setPickerError('Pick a time in the future.');
+      return;
+    }
+    onPick(at);
   }
 
   return (
@@ -47,7 +69,10 @@ export function CustomTimePicker({
         <input
           ref={inputRef}
           value={text}
-          onChange={(e) => setText(e.target.value)}
+          onChange={(e) => {
+            setText(e.target.value);
+            setPickerError(null);
+          }}
           onKeyDown={(e) => {
             // Stop Enter/Escape reaching the menu that owns this popover.
             e.stopPropagation();
@@ -85,18 +110,41 @@ export function CustomTimePicker({
             : 'Type a time, or press Enter to confirm'}
       </p>
 
-      <input
-        type="datetime-local"
-        aria-label="Pick a date and time"
-        onChange={(e) => {
-          const v = e.target.value;
-          if (!v) return;
-          const at = new Date(v);
-          if (!Number.isNaN(at.getTime()) && at.getTime() > Date.now()) onPick(at);
-        }}
-        onKeyDown={(e) => e.stopPropagation()}
-        className="type-caption h-8 w-full rounded-lg border bg-surface px-2 text-muted-foreground outline-none focus:border-brand"
-      />
+      {/* Confirmed explicitly rather than on change: a datetime-local fires as
+          soon as the fields happen to form a valid value, so committing there
+          acted on a date the user was still halfway through editing. */}
+      <div className="flex items-center gap-1.5">
+        <input
+          type="datetime-local"
+          aria-label="Pick a date and time"
+          value={exact}
+          min={new Date(Date.now() - new Date().getTimezoneOffset() * 60_000)
+            .toISOString()
+            .slice(0, 16)}
+          onChange={(e) => {
+            setExact(e.target.value);
+            setPickerError(null);
+          }}
+          onKeyDown={(e) => {
+            e.stopPropagation();
+            if (e.key === 'Enter') {
+              e.preventDefault();
+              commitExact();
+            }
+          }}
+          className="type-caption h-8 flex-1 rounded-lg border bg-surface px-2 text-muted-foreground outline-none focus:border-brand"
+        />
+        <button
+          type="button"
+          onClick={commitExact}
+          disabled={!exact}
+          className="type-caption h-8 shrink-0 rounded-lg border px-2.5 transition-colors hover:bg-accent disabled:opacity-40"
+        >
+          Set
+        </button>
+      </div>
+
+      {pickerError && <p className="type-caption px-1 text-destructive">{pickerError}</p>}
     </div>
   );
 }

apps/web/src/lib/find-in-text.ts

@@ -24,9 +24,11 @@ export function findOffsets(haystack: string, needle: string): number[] {
     const at = hay.indexOf(pin, from);
     if (at === -1) return out;
     out.push(at);
-    // Advance by one, not by the needle length: overlapping matches ("aa" in
-    // "aaa") are still two places a person would expect to be taken to.
-    from = at + 1;
+    // Advance by the needle length so this agrees exactly with highlightRuns,
+    // which cannot render overlapping matches without duplicating the
+    // characters they share. Counting a hit that has no highlight to jump to
+    // makes "3 of 5" a lie.
+    from = at + pin.length;
   }
 }
 
@@ -42,7 +44,7 @@ export function highlightRuns(
   const runs: Array<{ text: string; match: boolean }> = [];
   let cursor = 0;
   for (const at of offsets) {
-    // Overlapping matches would double-render the same characters.
+    // findOffsets no longer emits overlaps; this keeps the invariant local.
     if (at < cursor) continue;
     if (at > cursor) runs.push({ text: text.slice(cursor, at), match: false });
     runs.push({ text: text.slice(at, at + needle.length), match: true });

apps/web/src/lib/parse-time.ts

@@ -17,17 +17,17 @@
  *    than being asked to pick.
  */
 
-const WEEKDAYS: Record<string, number> = {
+const WEEKDAYS: Record<string, number> = Object.assign(Object.create(null), {
   sun: 0, sunday: 0,
   mon: 1, monday: 1,
   tue: 2, tues: 2, tuesday: 2,
   wed: 3, weds: 3, wednesday: 3,
   thu: 4, thur: 4, thurs: 4, thursday: 4,
   fri: 5, friday: 5,
   sat: 6, saturday: 6,
-};
+});
 
-const MONTHS: Record<string, number> = {
+const MONTHS: Record<string, number> = Object.assign(Object.create(null), {
   jan: 0, january: 0,
   feb: 1, february: 1,
   mar: 2, march: 2,
@@ -40,14 +40,14 @@ const MONTHS: Record<string, number> = {
   oct: 9, october: 9,
   nov: 10, november: 10,
   dec: 11, december: 11,
-};
+});
 
-const UNIT_MS: Record<string, number> = {
+const UNIT_MS: Record<string, number> = Object.assign(Object.create(null), {
   m: 60_000, min: 60_000, mins: 60_000, minute: 60_000, minutes: 60_000,
   h: 3_600_000, hr: 3_600_000, hrs: 3_600_000, hour: 3_600_000, hours: 3_600_000,
   d: 86_400_000, day: 86_400_000, days: 86_400_000,
   w: 604_800_000, week: 604_800_000, weeks: 604_800_000,
-};
+});
 
 /** Default hour when a day is named without a time. */
 const DEFAULT_HOUR = 9;
@@ -72,7 +72,9 @@ function extractTime(input: string): { time: TimeOfDay | null; rest: string } {
     return { time: { hour, minute: 0 }, rest: input.replace(named[0], ' ') };
   }
 
-  const m = input.match(/\b(\d{1,2})(?::|\.)?(\d{2})?\s*(am|pm)?\b/);
+  // The trailing (?!\d) matters: without it a bare year like "2025" matches as
+  // 20:25, so "mar 4 2025" silently became 8:25pm.
+  const m = input.match(/\b(\d{1,2})(?::|\.)?(\d{2})?\s*(am|pm)?\b(?!\d)/);
   if (!m) return { time: null, rest: input };
 
   // A bare 1- or 2-digit number with no meridiem and no colon is only a time if
@@ -129,12 +131,22 @@ export function parseNaturalTime(input: string, now: Date = new Date()): Date |
   let working = raw;
   let monthIdx: number | null = null;
   let dayNum: number | null = null;
-  const monthWord = working.match(/\b[a-z]{3,9}\b/g)?.find((w) => w in MONTHS);
+  let yearNum: number | null = null;
+  const monthWord = working.match(/\b[a-z]{3,9}\b/g)?.find((w) => Object.hasOwn(MONTHS, w));
   if (monthWord) {
     monthIdx = MONTHS[monthWord]!;
+    // Pull an explicit year out before anything else can claim those digits.
+    const yearMatch = working.match(/\b(19|20)\d{2}\b/);
+    if (yearMatch) {
+      yearNum = Number(yearMatch[0]);
+      working = working.replace(yearMatch[0], ' ');
+    }
     working = working.replace(new RegExp(`\\b${monthWord}\\b`), ' ');
     // A number is the day only if no meridiem or clock separator claims it.
-    const dayMatch = working.match(/\b(\d{1,2})\b(?!\s*(?:am|pm)|[:.]\d)/);
+    // The lookbehind stops the MINUTES of a clock time being read as the day:
+    // in "mar 9:30" the 9 is rejected for having a colon after it, and without
+    // this the 30 would then be accepted as the day of the month.
+    const dayMatch = working.match(/(?<![:.\d])\b(\d{1,2})\b(?!\s*(?:am|pm)|[:.]\d)/);
     if (dayMatch) {
       dayNum = Number(dayMatch[1]);
       working = working.replace(dayMatch[0], ' ');
@@ -148,10 +160,13 @@ export function parseNaturalTime(input: string, now: Date = new Date()): Date |
   if (monthIdx !== null && dayNum !== null) {
     // Built from parts rather than mutated, so setting February on the 31st
     // cannot roll into March.
-    const at = new Date(now.getFullYear(), monthIdx, dayNum);
+    const at = new Date(yearNum ?? now.getFullYear(), monthIdx, dayNum);
     const result = atTime(at, time);
-    // A date that has already passed this year means next year.
-    if (result.getTime() <= now.getTime()) result.setFullYear(result.getFullYear() + 1);
+    // A date that has already passed means next year — but only when the year
+    // was inferred. An explicit "mar 4 2024" is a mistake, not next March.
+    if (yearNum === null && result.getTime() <= now.getTime()) {
+      result.setFullYear(result.getFullYear() + 1);
+    }
     return result;
   }
 
@@ -167,7 +182,7 @@ export function parseNaturalTime(input: string, now: Date = new Date()): Date |
     return atTime(d, time);
   }
 
-  const dayWord = words.find((w) => w in WEEKDAYS);
+  const dayWord = words.find((w) => Object.hasOwn(WEEKDAYS, w));
   if (dayWord) {
     const target = WEEKDAYS[dayWord]!;
     const d = new Date(now);