Skip to content

feat: create conjugation selection UI page with dummy data (#567)#614

Open
prince-0408 wants to merge 2 commits into
scribe-org:mainfrom
prince-0408:feat/conjugation-selection-ui-567
Open

feat: create conjugation selection UI page with dummy data (#567)#614
prince-0408 wants to merge 2 commits into
scribe-org:mainfrom
prince-0408:feat/conjugation-selection-ui-567

Conversation

@prince-0408

@prince-0408 prince-0408 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Description

Closes #567 , #568

Creates the conjugation selection UI page for the Conjugate app . The page displays dummy conjugation tables for a selected verb and is linked directly from the Conjugate tab.

Changes

New file

  • ConjugationSelectionScreen.kt — new screen that displays dummy conjugation tables (Indicative, Subjunctive, Imperative) for a selected verb. The page header shows verb (Language) based on the option the user selected, as specified in the Figma designs.

Modified files

  • Screen.kt — added ConjugationSelection route
  • App.kt — added import, navigation callback in ConjugateScreen, and the new composable destination for ConjugationSelectionScreen
  • ConjugateScreen.kt
    • Added onNavigateToConjugationSelection callback
    • Search dropdown now shows dummy rows using the typed query (e.g. typing laufen shows laufen (Deutsch), laufen (Español), etc.) — each row navigates to ConjugationSelectionScreen
    • Added "Choose a conjugation below" / "Select tense →" direct link card on the Conjugate tab
    • Recently conjugated section only shows real user history (hidden when empty)
  • ConjugateViewModel.kt
    • Added isDummy flag to ConjugateSearchResult
    • Added displayResults StateFlow with dummy fallback when DB data is not yet available
    • Fixed onVerbSelected to always persist selections to recently conjugated

Notes

Screenshots

Conjugate Tab Search Dropdown Conjugation Page Recently Conjugated
Conjugate Tab Search Dropdown Conjugation Page Recently Conjugated

Testing

  • Open the Conjugate app
  • Verify "Choose a conjugation below" card is visible on the Conjugate tab
  • Tap it → ConjugationSelectionScreen opens with header verb (Deutsch)
  • Type in the search bar → dropdown shows <query> (Deutsch), <query> (Español), etc.
  • Tap a dropdown row → navigates to ConjugationSelectionScreen with correct header
  • Back button returns to Conjugate tab
  • Selected verb appears in "Recently conjugated" section

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Thank you for the pull request! 💙🩵

The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Android rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis

Copy link
Copy Markdown
Member

Amazing to have this, @prince-0408! @angrezichatterbox and I will get to the review in the coming days :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create conjugation selection UI page

2 participants