Skip to content

Style Search Bar and Clear All button to match dark theme mockups (closes #612)#613

Merged
andrewtavis merged 3 commits into
scribe-org:mainfrom
prince-0408:feature/search-bar-styling
Jun 8, 2026
Merged

Style Search Bar and Clear All button to match dark theme mockups (closes #612)#613
andrewtavis merged 3 commits into
scribe-org:mainfrom
prince-0408:feature/search-bar-styling

Conversation

@prince-0408

Copy link
Copy Markdown
Contributor

Summary

This PR styles the search bar and the "Clear all" button on the Conjugate screen to match the dark theme mockup designs specified in #612.

Closes

Closes #612

Mockups vs Current

Old Design New Implementation

Changes Proposed

  • Search Bar:
    • Background color updated to MaterialTheme.colorScheme.surfaceContainer (dark brown/black background in dark mode).
    • Added a 1.dp border with MaterialTheme.colorScheme.outline color (gold/orange border).
    • Tinted all inner search bar icons (search, clear/close, play) and text (input text, cursor, placeholder text) to MaterialTheme.colorScheme.primary (gold/orange color) instead of solid Color.Black.
  • Clear All Button:
    • Background color updated to MaterialTheme.colorScheme.surfaceContainer and added a 1.dp MaterialTheme.colorScheme.outline border.
    • Set the text color to MaterialTheme.colorScheme.primary instead of Color.Black.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Thank you for the pull request! 💙🩵

The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Android rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@prince-0408 prince-0408 force-pushed the feature/search-bar-styling branch from 5a9b481 to c53c656 Compare June 8, 2026 10:25
@andrewtavis andrewtavis self-requested a review June 8, 2026 13:26
@andrewtavis

Copy link
Copy Markdown
Member

Thanks for the issue, @prince-0408 :) Dark mode is definitely looking better, but light mode needs a fix. Could you take a look?

Screenshot 2026-06-08 at 07 26 28

@prince-0408

Copy link
Copy Markdown
Contributor Author

Hi @andrewtavis, fixed the light mode styling adjusted text/icon contrast to display clearly on the orange background. Just pushed the changes!

Screenshot

Screenshot_20260608_191755

@andrewtavis andrewtavis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All's working great here now, @prince-0408! Thanks for the issue and the quick fix 😊

@andrewtavis

Copy link
Copy Markdown
Member

Bringing this in assuming the instrumentation tests will pass :) We'll make an issue if there's something new 😊

@andrewtavis andrewtavis merged commit 7ec4de8 into scribe-org:main Jun 8, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Match Search Bar and Clear All button styling with Dark Theme

2 participants