Style Search Bar and Clear All button to match dark theme mockups (closes #612)#613
Conversation
Thank you for the pull request! 💙🩵The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
5a9b481 to
c53c656
Compare
|
Thanks for the issue, @prince-0408 :) Dark mode is definitely looking better, but light mode needs a fix. Could you take a look?
|
|
Hi @andrewtavis, fixed the light mode styling adjusted text/icon contrast to display clearly on the orange background. Just pushed the changes! Screenshot
|
andrewtavis
left a comment
There was a problem hiding this comment.
All's working great here now, @prince-0408! Thanks for the issue and the quick fix 😊
|
Bringing this in assuming the instrumentation tests will pass :) We'll make an issue if there's something new 😊 |


Summary
This PR styles the search bar and the "Clear all" button on the
Conjugatescreen to match the dark theme mockup designs specified in #612.Closes
Closes #612
Mockups vs Current
Changes Proposed
MaterialTheme.colorScheme.surfaceContainer(dark brown/black background in dark mode).MaterialTheme.colorScheme.outlinecolor (gold/orange border).MaterialTheme.colorScheme.primary(gold/orange color) instead of solidColor.Black.MaterialTheme.colorScheme.surfaceContainerand added a 1.dpMaterialTheme.colorScheme.outlineborder.MaterialTheme.colorScheme.primaryinstead ofColor.Black.